Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies between --hgvs and --hgvsg #1750

Merged

Conversation

nuno-agostinho
Copy link
Contributor

@nuno-agostinho nuno-agostinho commented Sep 3, 2024

ENSVAR-3174

Changelog

  1. Currently, asking for HGVSg using offline and without FASTA, returns HGVSg using Ns as reference sequence. The correct behaviour would be to mimic what is done with HGVS and error out.
  2. When accessing the database to retrieve sequence for HGVSg, a warning should be printed informing the user of such (like done for HGVS).
  3. When retrieving sequence from database using --hgvs, the message is printed three times:
2024-09-03 13:25:00 - INFO: Database will be accessed when using --hgvs
2024-09-03 13:25:00 - INFO: Database will be accessed when using --hgvsc
2024-09-03 13:25:00 - INFO: Database will be accessed when using --hgvsp

As --hgvsc and --hgvsp are internal parameters (not VEP arguments), they should be omitted from the message.

Testing

  1. vep --hgvsg --offline --cache $vep_cache --id "1 230710048 rs699 A G" --force should raise an error:

    MSG: ERROR: Cannot generate HGVS coordinates (--hgvs and --hgvsg) in offline mode without a FASTA file (see --fasta)
    
  2. vep --hgvsg --cache $vep_cache --id "1 230710048 rs699 A G" --force should warn that the database will be accessed to retrieve the sequence:

    2024-09-03 13:21:27 - INFO: Database will be accessed when using --hgvsg
    
  3. vep --hgvs --cache $vep_cache --id "1 230710048 rs699 A G" --force should only warn that the database is accessed to retrieve the sequence for --hgvs.

@likhitha-surapaneni likhitha-surapaneni self-assigned this Sep 4, 2024
Copy link
Contributor

@likhitha-surapaneni likhitha-surapaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected. Thank you @nuno-agostinho

@likhitha-surapaneni likhitha-surapaneni merged commit c03a7f8 into Ensembl:postreleasefix/113 Sep 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants