Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing filter when value is hash and contains text and number #1739

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fixing filter when value is hash and contains text and number #1739

merged 2 commits into from
Aug 13, 2024

Conversation

likhitha-surapaneni
Copy link
Contributor

Issue: #1723

Testing

filter_vep -i input.vcf --filter "HGNC_ID in HGNC:4836,HGNC:4826" --only_matched 
filter_vep -i input.vcf --filter "HGNC_ID in hgnc.txt" --only_matched 
filter_vep -i input.vcf --filter "HGNC_ID is HGNC:4836" --only_matched

@nuno-agostinho nuno-agostinho self-assigned this Aug 12, 2024
@nuno-agostinho nuno-agostinho self-requested a review August 12, 2024 09:32
nuno-agostinho
nuno-agostinho approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@nuno-agostinho nuno-agostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended, thanks @likhitha-surapaneni!

@nuno-agostinho nuno-agostinho merged commit f383f90 into Ensembl:postreleasefix/113 Aug 13, 2024
1 check passed
@nuno-agostinho
Copy link
Contributor

Merged to main and release/113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-agostinho nuno-agostinho nuno-agostinho approved these changes

Assignees

@nuno-agostinho nuno-agostinho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@likhitha-surapaneni @nuno-agostinho