Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SV warnings for short variants in region format #1618

Merged

Conversation

nuno-agostinho
Copy link
Contributor

@nuno-agostinho nuno-agostinho commented Feb 21, 2024

Fixes #1617: when inputting short variants in region format, VEP prints a warning message:

WARNING: line 1 skipped (12:9079672-9079672:C): C type is not supported

Also, unknown SV types in region format are incorrectly returned with no warning.

Changelog

This PR does the following:

  • Remove the nonsense warning for short variants in region format
  • Throw warning (and do not return output) when using SVs whose type is not supported

Testing

Ensure that running VEP with the following variants works without warnings1:

12:9079672-9079672:C
12:9079672-9079672:DUP
12:9079672-9079672:INS:ME
12:9079672-9079672:INS:ME:LINE1

Ensure that running VEP with the following variants does not print output (only warnings):

12:9079672-9079672:RANDOM
12:9079672-9079672:DELTEST

Footnotes

  1. The last two examples require https://github.com/Ensembl/ensembl-variation/pull/1071

@nuno-agostinho nuno-agostinho marked this pull request as ready for review February 21, 2024 14:42
@nuno-agostinho nuno-agostinho changed the title Fix SV warnings for short variants in regions format Fix SV warnings for short variants in region format Feb 21, 2024
Copy link
Contributor

@olaaustine olaaustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, first test returns output and no warnings, second returns no output and warnings. Same result with the SNP

@olaaustine olaaustine merged commit e10125c into Ensembl:postreleasefix/112 Mar 4, 2024
1 check passed
@nuno-agostinho nuno-agostinho deleted the fix/REST-SV-warnings branch March 4, 2024 17:34
@olaaustine
Copy link
Contributor

Merged into main and release/112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants