Skip to content

Commit 780862b

Browse files
committed
Rename vep option and patch dbs
1 parent 760d043 commit 780862b

File tree

7 files changed

+16
-20
lines changed

7 files changed

+16
-20
lines changed

modules/Bio/EnsEMBL/VEP/Config.pm

+4-4
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,10 @@ our @VEP_PARAMS = (
149149
'nearest=s', # get nearest transcript, gene or symbol (for gene)
150150
'distance=s', # set up/downstream distance
151151
'clin_sig_allele=i', # use allele specific clinical significance data where it exists
152-
'somatic_classification', # report the somatic classification of a variant as reported by ClinVar
153-
'overlaps', # report length and percent of a transcript or regulatory feature overlaped with a SV
154-
'max_sv_size=i', # modify the size of structural variant to be handled (limited by default to reduce memory requirements)
155-
'remove_hgvsp_version', # removes translation version from hgvs_protein output
152+
'clinvar_somatic_classification', # report the somatic classification of a variant as reported by ClinVar
153+
'overlaps', # report length and percent of a transcript or regulatory feature overlaped with a SV
154+
'max_sv_size=i', # modify the size of structural variant to be handled (limited by default to reduce memory requirements)
155+
'remove_hgvsp_version', # removes translation version from hgvs_protein output
156156

157157

158158
# verbosity options

modules/Bio/EnsEMBL/VEP/Constants.pm

+2-2
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ our @FLAG_FIELDS = (
7979
{ flag => 'minimal', fields => ['MINIMISED']},
8080
{ flag => 'spdi', fields => ['SPDI']},
8181
{ flag => 'ga4gh_vrs', fields => ['GA4GH_VRS']},
82-
{ flag => 'somatic_classification', fields => ['SOMATIC_CLASSIFICATION']},
82+
{ flag => 'clinvar_somatic_classification', fields => ['CLINVAR_SOMATIC_CLASSIFICATION']},
8383

8484
# gene-related
8585
{ flag => 'symbol', fields => ['SYMBOL','SYMBOL_SOURCE','HGNC_ID'] },
@@ -237,7 +237,7 @@ our %FIELD_DESCRIPTIONS = (
237237
'MAX_AF_POPS' => 'Populations in which maximum allele frequency was observed',
238238
'DISTANCE' => 'Shortest distance from variant to transcript',
239239
'CLIN_SIG' => 'ClinVar clinical significance of the dbSNP variant',
240-
'SOMATIC_CLASSIFICATION' => 'ClinVar somatic classification of the dbSNP variant',
240+
'CLINVAR_SOMATIC_CLASSIFICATION' => 'ClinVar somatic classification of the dbSNP variant',
241241
'BIOTYPE' => 'Biotype of transcript or regulatory feature',
242242
'PUBMED' => 'Pubmed ID(s) of publications that cite existing variant',
243243
'ALLELE_NUM' => 'Allele number from input; 0 is reference, 1 is first alternate etc',

modules/Bio/EnsEMBL/VEP/OutputFactory.pm

+3-5
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ use Bio::EnsEMBL::VEP::OutputFactory::VEP_output;
8484
use Bio::EnsEMBL::VEP::OutputFactory::VCF;
8585
use Bio::EnsEMBL::VEP::OutputFactory::Tab;
8686

87-
use Data::Dumper;
88-
8987
our $CAN_USE_JSON;
9088

9189
BEGIN {
@@ -176,7 +174,7 @@ sub new {
176174
max_af
177175
pubmed
178176
clin_sig_allele
179-
somatic_classification
177+
clinvar_somatic_classification
180178
181179
numbers
182180
domains
@@ -1047,8 +1045,8 @@ sub add_colocated_variant_info {
10471045
push @{$hash->{VAR_SYNONYMS}}, $ex->{var_synonyms} if $self->{var_synonyms} && $ex->{var_synonyms} && !$self->{_config}->{_params}->{is_vr};
10481046

10491047
# ClinVar somatic classification
1050-
if(defined($ex->{clinical_impact}) && $self->{somatic_classification}) {
1051-
$hash->{SOMATIC_CLASSIFICATION} = $ex->{clinical_impact};
1048+
if(defined($ex->{clinical_impact}) && $self->{clinvar_somatic_classification}) {
1049+
$hash->{CLINVAR_SOMATIC_CLASSIFICATION} = $ex->{clinical_impact};
10521050
}
10531051

10541052
if(defined($ex->{clin_sig_allele}) && $self->{clin_sig_allele} )

modules/Bio/EnsEMBL/VEP/OutputFactory/JSON.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ my %RENAME_KEYS = (
108108
'chr' => 'seq_region_name',
109109
'variation_name' => 'id',
110110
'sv' => 'colocated_structural_variants',
111-
'clinical_impact' => 'somatic_classification'
111+
'clinical_impact' => 'clinvar_somatic_classification'
112112
);
113113

114114
my %NUMBERIFY_EXEMPT = (

t/Runner.t

+1
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ is_deeply($runner->get_OutputFactory, bless( {
235235
'clin_sig_allele' => 1,
236236
'var_synonyms' => undef,
237237
'ga4gh_vrs' => undef,
238+
'clinvar_somatic_classification' => undef,
238239
}, 'Bio::EnsEMBL::VEP::OutputFactory::VEP_output' ), 'get_OutputFactory');
239240

240241

t/test-genome-DBs/homo_vepiens/variation/meta.txt

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
1 \N schema_type variation
2-
2 \N schema_version 114
2+
2 \N schema_version 115
33
3 \N patch patch_73_74_a.sql|schema version
44
4 \N patch patch_73_74_b.sql|Add doi and UCSC id to publication table
55
5 \N patch patch_73_74_c.sql|Add clinical_significance to variation_feature table
@@ -133,13 +133,9 @@
133133
164 \N patch patch_107_108_a.sql|schema version
134134
165 \N patch patch_107_108_b.sql|fix SAS population description
135135
166 \N patch patch_108_109_a.sql|schema version
136-
167 \N patch patch_109_110_a.sql|schema version
137-
168 \N patch patch_109_110_b.sql|Add DDG2P data_source_attrib to variation_citation
138-
169 \N patch patch_109_110_c.sql|Add new clinical_significance values to variation, variation_feature and structural_variation
139-
170 \N patch patch_110_111_a.sql|schema version
140-
171 \N patch patch_110_111_b.sql|Update transcript_variation primary key
141-
172 \N patch patch_111_112_a.sql|schema version
142136
173 \N patch patch_111_112_a.sql|schema version
143137
174 \N patch patch_112_113_a.sql|schema version
144138
175 \N patch patch_112_113_b.sql|Update meta_key length
145139
176 \N patch patch_113_114_a.sql|schema version
140+
177 \N patch patch_114_115_a.sql|schema version
141+
178 \N patch patch_114_115_b.sql|Add column DNA_type to phenotype_feature

t/test-genome-DBs/homo_vepiens/variation/table.sql

+2-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ CREATE TABLE `meta` (
186186
PRIMARY KEY (`meta_id`),
187187
UNIQUE KEY `species_key_value_idx` (`species_id`,`meta_key`,`meta_value`),
188188
KEY `species_value_idx` (`species_id`,`meta_value`)
189-
) ENGINE=MyISAM AUTO_INCREMENT=177 DEFAULT CHARSET=latin1;
189+
) ENGINE=MyISAM AUTO_INCREMENT=179 DEFAULT CHARSET=latin1;
190190

191191
CREATE TABLE `meta_coord` (
192192
`table_name` varchar(40) NOT NULL,
@@ -239,6 +239,7 @@ CREATE TABLE `phenotype_feature` (
239239
`seq_region_start` int(11) unsigned DEFAULT NULL,
240240
`seq_region_end` int(11) unsigned DEFAULT NULL,
241241
`seq_region_strand` tinyint(4) DEFAULT NULL,
242+
`DNA_type` enum('Germline','Somatic') DEFAULT NULL,
242243
PRIMARY KEY (`phenotype_feature_id`),
243244
KEY `phenotype_idx` (`phenotype_id`),
244245
KEY `object_idx` (`object_id`,`type`),

0 commit comments

Comments
 (0)