Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DisGeNET (release 114) #670

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

dglemos
Copy link
Contributor

@dglemos dglemos commented Dec 11, 2024

This is an update for release 114

Description

Deprecating the VEP plugin: DisGeNET

Use case

The DisGeNET data is not freely available anymore.
The plugin does not make sense without the data.

Benefits

Possible Drawbacks

Users won't be able to run the plugin in the future.

Testing

Have you added/modified unit tests to test the changes?

If so, do the tests pass/fail?

Have you run the entire test suite and no regression was detected?
no regression detected

Changelog

[/vep] DisGeNET plugin is deprecated
[/ga4gh/beacon/query] Beacon does not return DisGeNET scores anymore

@dglemos
Copy link
Contributor Author

dglemos commented Dec 11, 2024

@jamie-m-a this is the PR to deprecate the DisGeNET in REST, let me know if there is something that needs to be updated.

Copy link
Contributor

@jamie-m-a jamie-m-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks Diana

Copy link
Contributor

@nwillhoft nwillhoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing DisGeNET plugin on the main branch. Changes look good and are approved by Variation team.

@nwillhoft nwillhoft merged commit 8cba57b into Ensembl:main Dec 12, 2024
1 check passed
@nwillhoft
Copy link
Contributor

@dglemos Please would it be possible to create a duplicate PR against the release/114 branch as well? Thanks

@dglemos dglemos mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants