Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regulatory activity viewer: epigenome selection #1188

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

azangru
Copy link
Collaborator

@azangru azangru commented Dec 9, 2024

Description

  • When user starts interacting with regulatory activity viewer, he should see a list of pre-selected epigenomes (in a table), if it is provided by the backend
  • User should be able to select other epigenomes. The selector (lists of checkboxes) appears as a modal dialog popup upon a click on the "Configure" button.
    • Checkboxes act as filters. Within a single list of checkboxes (a metadata dimension), selection of different checkboxes acts as a logical "OR" operator. Selecting checkboxes from different lists (different metadata dimensions) acts as a logical "AND" operator.
  • The ticked selection criteria for epigenomes (filters) will appear in the sidebar, where they can be deleted.
  • Selected epigenomes appear in the table at the bottom of the sceen
  • Some of the metadata dimensions of an epigenome can be used to "combine" the epigenomes. Currently, this is done by clicking appropriate table column headings.

Other changes

  • This PR also introduces a new component — CollapsibleSection, which seems to be better suited than Accordion for showing and hiding elements in the sidebar
epigenome-selection.mp4

This is a very rough approximation of the XD. Lots of things don't work quite as in the XD; but since the diff is already huge as it is, it will be useful to merge this PR with its current scope of changes.

Deployment URL(s)

http://activity-viewer-metadata.review.ensembl.org

- Added EpigenomeSelectionModal
- Showing epigenome filters in the sidebar (EpigenomeFiltersView component)
- Added CollapsibleSection shared component for collapsible sections in the sidebar
@azangru azangru force-pushed the activity-viewer-metadata branch from ab1c6de to dc691af Compare December 9, 2024 10:26
@azangru azangru marked this pull request as ready for review December 11, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant