Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The matches list is empty when viewing the index #3

Open
Serneum opened this issue Jun 27, 2017 · 6 comments
Open

The matches list is empty when viewing the index #3

Serneum opened this issue Jun 27, 2017 · 6 comments

Comments

@Serneum
Copy link
Member

Serneum commented Jun 27, 2017

This will likely be best if the list is in reverse order (most recent games first) and with pagination (probably with Scrivener.Ecto and Scrivener.HTML, or kerosene)

@Serneum
Copy link
Member Author

Serneum commented Jun 29, 2017

@jlholm I'm considering hijacking your work around displaying the matches. Thoughts?

image

@jlholm
Copy link
Contributor

jlholm commented Jun 29, 2017

My only concern is that it might look too busy. We can try it and see how it looks. I don't mind coming up with a new design if needed. Also, I have to add some sass styles to fix the scaling on them

@jlholm
Copy link
Contributor

jlholm commented Jun 29, 2017

@Serneum What if we sorted matches by date instead of pagination? This way, it only shows X matches on certain dates instead of continually showing all the matches which would become cluttered. We would have buttons to go to the next day, previous day, or a user inputted day?

@Serneum
Copy link
Member Author

Serneum commented Jun 29, 2017

I'm not sure the libraries I listed would support that. We might be able to look into Rummage and see if it can help. (Example)

@Serneum
Copy link
Member Author

Serneum commented Jun 29, 2017

Pagination also doesn't look too great
image

It's currently trying to use Bootstrap, but you are using Spectre. There is no existing Spectre theme for Scrivener or Kerosene

As for paginating by date, we might be able to hack something together by looking at what Kerosene does

@Serneum
Copy link
Member Author

Serneum commented Jun 29, 2017

Maybe we can hack get_total_pages to look for the number of distinct dates in the database. We'd probably need to find a way to override per_page to be unlimited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants