Skip to content

Commit c48959b

Browse files
author
OSREC
committed
Version 1.0.2 - ironed out a few small bugs with negatives and zeros
1 parent 53ed35b commit c48959b

File tree

4 files changed

+44
-36
lines changed

4 files changed

+44
-36
lines changed

currencyFormatter.js

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1157,24 +1157,6 @@ OSREC.CurrencyFormatter =
11571157

11581158
return encodedPattern;
11591159
};
1160-
1161-
// Use encode function to work out pattern
1162-
1163-
var patternArray = pattern.split(";");
1164-
1165-
var positiveFormat = encodePattern(patternArray[0]);
1166-
var negativeFormat = isUndefined(patternArray[1]) ? encodePattern("-" + patternArray[0]) : encodePattern(patternArray[1]);
1167-
var zeroFormat = positiveFormat;
1168-
1169-
if(!isUndefined(patternArray[2])) { zeroFormat = patternArray[2]; }
1170-
1171-
positiveFormat.symbol = symbol;
1172-
positiveFormat.decimal = decimal;
1173-
positiveFormat.group = group;
1174-
1175-
negativeFormat.symbol = symbol;
1176-
negativeFormat.decimal = decimal;
1177-
negativeFormat.group = group;
11781160

11791161
// Zero Padding helper function
11801162

@@ -1225,14 +1207,36 @@ OSREC.CurrencyFormatter =
12251207

12261208
return formattedNumber.replace('!', symbol);
12271209

1228-
};
1210+
};
1211+
1212+
// Use encode function to work out pattern
1213+
1214+
var patternArray = pattern.split(";");
1215+
1216+
var positiveFormat = encodePattern(patternArray[0]);
1217+
1218+
positiveFormat.symbol = symbol;
1219+
positiveFormat.decimal = decimal;
1220+
positiveFormat.group = group;
1221+
1222+
var negativeFormat = isUndefined(patternArray[1]) ? encodePattern("-" + patternArray[0]) : encodePattern(patternArray[1]);
1223+
1224+
negativeFormat.symbol = symbol;
1225+
negativeFormat.decimal = decimal;
1226+
negativeFormat.group = group;
1227+
1228+
var zero = isUndefined(patternArray[2]) ? format(0, positiveFormat) : patternArray[2];
1229+
1230+
if(!isUndefined(patternArray[2])) { zeroFormat = patternArray[2]; }
1231+
1232+
12291233

12301234
return function(n)
12311235
{
12321236
var formattedNumber;
12331237
n = Number(n);
12341238
if(n > 0) { formattedNumber = format(n, positiveFormat); }
1235-
else if(n == 0) { formattedNumber = zeroFormat.replace('!', symbol); }
1239+
else if(n == 0) { formattedNumber = zero.replace('!', symbol); }
12361240
else { formattedNumber = format(n, negativeFormat); }
12371241
return formattedNumber;
12381242
};

currencyFormatter.min.js

Lines changed: 9 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/currencyFormatter.min.js

Lines changed: 9 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,8 +262,8 @@ <h4 class='subheading'>&rsaquo; Example 1: Format all element values as currency
262262
<div class='codeHeader'>HTML</div>
263263
<div class='clear'></div>
264264
<pre><code class="html">
265-
&lt;div class='money'&gt; 1234564 &lt;/div&gt;
266-
&lt;div class='money'&gt; 8798583 &lt;/div&gt;
265+
&lt;div class='money'&gt; 1234536.32 &lt;/div&gt;
266+
&lt;div class='money'&gt; 8798458.11 &lt;/div&gt;
267267

268268
</code></pre>
269269

0 commit comments

Comments
 (0)