Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHPStan #195

Draft
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Draft

Add PHPStan #195

wants to merge 2 commits into from

Conversation

IonBazan
Copy link
Contributor

This PR attempts to add PHPStan analysis to CI process.

Changes include:

  • Using phpunit/phpunit to make it easier for PHPStan to discover its classes (symfony/phpunit-bridge no longer conflicts with it)
  • Add some missing return types (this could potentially be a BC break if someone extends one of these classes and uses different return type)

To do:

  • Add missing iterable types
  • Resolve templates issues (shadowing, etc)
  • Add more missing types

@ogizanagi ogizanagi added this to the 2.x milestone Jun 20, 2022
@ogizanagi ogizanagi linked an issue Jun 20, 2022 that may be closed by this pull request
[CI] Introduce a Psalm/PhpStan check #194
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.x
Development

Successfully merging this pull request may close these issues.

[CI] Introduce a Psalm/PhpStan check
2 participants
@IonBazan @ogizanagi