Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add walking and jumping effect to characters #131

Open
Aseged opened this issue Feb 24, 2018 · 12 comments
Open

Add walking and jumping effect to characters #131

Aseged opened this issue Feb 24, 2018 · 12 comments

Comments

@Aseged
Copy link

Aseged commented Feb 24, 2018

Adde jumping and walking effect on this character.
Hint: it is necessary to use photoshop to create a copy of the same character but in different positions, much like sprite sheet but different png files. @EdwardDunn

@EdwardDunn
Copy link
Owner

@Aseged Sounds good!

@Scruffy21
Copy link
Contributor

Hi @Aseged , how are you coming along with this? If you're no longer working on the character animations then I would take this issue. There are free spritesheets for all kinds of actions for these characters on https://www.gameart2d.com, and they would finally be walking and jumping instead of sliding!

@EdwardDunn
Copy link
Owner

@Scruffy21 Go ahead, I don't think @Aseged is working on this anymore.

@EdwardDunn EdwardDunn changed the title Add walking and jumping effect to 'ninja' character Add walking and jumping effect to characters Apr 25, 2018
@Aseged
Copy link
Author

Aseged commented Apr 25, 2018

Apologies @EdwardDunn @Scruffy21 I have been really busy with other projects and will be for another 3 weeks. Go ahead with the issue.

@Scruffy21
Copy link
Contributor

Okay then. Thanks. I should do this sometime this week.

@Scruffy21
Copy link
Contributor

I didn't get to doing it yet, but I should do it in some time though, I promise.

@EdwardDunn
Copy link
Owner

@Scruffy21 No worries, take your time.

@Scruffy21
Copy link
Contributor

I noticed that the current images for the characters all have different dimensions, and so they are squished to the same size and that causes them to be sorta blurred. The aspect ratio for the character images is currently 70/60 = 1.16, while the boy img has 486/309 = 1.57, girl 491/344 = 1.42 Any idea how to resolve this? Or do we just ignore them and let them be distorted for the time being?

@EdwardDunn
Copy link
Owner

@Scruffy21 The only solution I can think of is to use an image editor like Photoshop to make them all consistent, an alternative would be the Gimp software that is free but a bit unintuitive to use.

@Scruffy21
Copy link
Contributor

I see. I'm not so good with image editing software, and there'd be something like 338 = 72 images to edit. So probably some bulk editing needed. I think I'll just let them a bit misshapen and see how it looks, and when someone comes around with good photoshop skills they could fix it to look better.

@EdwardDunn
Copy link
Owner

@Scruffy21 It could be done programmatically but probably cleaner to use correctly scaled images. Thanks for your input!

@Scruffy21
Copy link
Contributor

I'll let someone better at Photoshop deal with this issue then. Doing it programmatically would be a real pain, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants