Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade extJS 4.2 to 7.x #375

Open
3 tasks
nikobeer opened this issue May 14, 2024 · 5 comments
Open
3 tasks

Upgrade extJS 4.2 to 7.x #375

nikobeer opened this issue May 14, 2024 · 5 comments
Assignees
@daniel-jettka @hizclick
Labels
Area: Build & deploy Area: JS Status: needs work
Milestone
1.1.0

Comments

@nikobeer
Copy link
Member

nikobeer commented May 14, 2024 •
edited by daniel-jettka
Loading

Use extJS Upgrade advisor. https://www.sencha.com/products/extjs/upgradeadviser/
Upgrade in several steps to respective next major version (GPL versions)
@bwbohl
Copy link
Member

bwbohl commented May 14, 2024 •
edited by Diginaut
Loading

Check Assignee Fixable Severity Rule Filepath Message Line Column
[ ] Warning @sencha/extjs/no-private-method-call /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/image/ImageViewer.js Call to private method 'onMouseDown' found for 'Ext.panel.Panel' 112 33
[ ] @hizclick Warning @sencha/extjs/no-private-method-call /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Call to private method 'callback' found for 'Ext.window.Window' 624 9
[ ] @hizclick Warning @sencha/extjs/no-private-method-call /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Call to private method 'callback' found for 'Ext.window.Window' 624 9
[ ] @hizclick Warning @sencha/extjs/no-private-method-call /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Call to private method 'callback' found for 'Ext.window.Window' 624 9
9c853e7 @hizclick Error @sencha/extjs/no-removed-method-call /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/grid/menu/ListMenu.js Call to removed method 'type' found for 'Ext' 65 24
[ ] Error @sencha/extjs/no-removed-method-call /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Call to removed method 'getKeyMap' found for 'Ext.window.Window' 603 19
[ ] Yes Warning @sencha/extjs/no-deprecated-method-call /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/grid/menu/ListMenu.js Call to deprecated method 'type' found for 'Ext'. Use {@link Ext#method!typeOf Ext#typeOf} instead 65 24
[ ] Warning @sencha/extjs/no-private-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/image/ImageViewer.js Override of private method 'onMouseDown' found for 'Ext.Component' 568 5
[ ] Warning @sencha/extjs/no-private-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/grid/filter/Filter.js Override of private method 'destroy' found for 'Ext.util.Observable' 98 5
[ ] Warning @sencha/extjs/no-private-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/grid/FiltersFeature.js Override of private method 'destroy' found for 'Ext.grid.feature.Feature' 398 5
[ ] Warning @sencha/extjs/no-existing-alias-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/desktop/Desktop.js Override of existing alias 'widget.desktop' found for 'Ext.ux.desktop.Desktop'. 26 5
[ ] Warning @sencha/extjs/no-existing-alias-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/desktop/TaskBar.js Override of existing alias 'widget.taskbar' found for 'Ext.ux.desktop.TaskBar'. 32 5
[ ] Warning @sencha/extjs/no-existing-alias-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/desktop/TaskBar.js Override of existing alias 'widget.trayclock' found for 'Ext.ux.desktop.TrayClock'. 382 5
[ ] Warning @sencha/extjs/no-existing-alias-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/desktop/Wallpaper.js Override of existing alias 'widget.wallpaper' found for 'Ext.ux.desktop.Wallpaper'. 16 5
4ce7eeb @hizclick Error @sencha/extjs/no-removed-class-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Usage of removed Class 'Ext.EventObject' found. 606 18
4ce7eeb @hizclick Error @sencha/extjs/no-removed-class-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Usage of removed Class 'Ext.EventObject' found. 612 18
a170673 @bwbohl Warning @sencha/extjs/no-deprecated-class-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/desktop/App.js Usage of deprecated Class 'Ext.EventManager' found. Please use the Ext.dom.Element api to attach listeners to DOM Elements 70 9
4ce7eeb @hizclick Error @sencha/extjs/no-removed-property-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Usage of removed property 'ENTER' found for 'Ext.EventObject' 606 18
4ce7eeb @hizclick Error @sencha/extjs/no-removed-property-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Usage of removed property 'ESC' found for 'Ext.EventObject' 612 18
4a3ccb6 @DennisFriedl Error @sencha/extjs/no-removed-property-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/classic/src/view/main/Main.js Usage of removed property 'tabBar' found for 'Ext.tab.Panel' 43 5
7fac70b @daniel-jettka Warning @sencha/extjs/no-private-config-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/util/PageSpinner.js Usage of private config 'displayField' found for 'Ext.form.ComboBox' 50 13
[ ] @daniel-jettka Warning @sencha/extjs/no-private-config-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/MeasureBasedView.js Usage of private config 'displayField' found for 'Ext.form.ComboBox' 73 13
[ ] @daniel-jettka Warning @sencha/extjs/no-private-config-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/MeasureBasedView.js Usage of private config 'displayField' found for 'Ext.form.ComboBox' 739 13
[ ] @daniel-jettka Warning @sencha/extjs/no-private-config-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/SourceView.js Usage of private config 'displayField' found for 'Ext.form.ComboBox' 564 13
[ ] Warning @sencha/extjs/no-private-class-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/resources/js/ace/ace.js Usage of private Class 'width' found. 1 289312
[ ] @bwbohl Warning @sencha/extjs/no-private-class-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/resources/js/tipped/tipped.js Usage of private Class 'height' found. 503 17
[ ] Warning @sencha/extjs/no-private-class-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/resources/js/tipped/tipped.js Usage of private Class 'width' found. 504 16
[ ] Warning @sencha/extjs/no-private-class-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/resources/js/verovio-view.js Usage of private Class 'height' found. 16 33
[ ] Warning @sencha/extjs/no-private-class-usage /Volumes/VCS/GitHub/Edirom/Edirom-Online/resources/js/verovio-view.js Usage of private Class 'width' found. 17 32

hizclick added a commit that referenced this issue May 14, 2024
@hizclick
Resolving issue #375
4ce7eeb 
Update  Ext.EventObject to  Ext.event.Event
@daniel-jettka
Copy link
Contributor

daniel-jettka commented May 14, 2024 •
edited
Loading

User interface overrides (maybe intentionally and not needed to fix...)

Check Assignee Fixable Severity Rule Filepath Message Line Column
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/utils/EnhancedSlider.js Override of existing method 'setData', for the 'data' config, found for 'Ext.slider.Single'. 38 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/concordanceNavigator/ConcordanceNavigator.js Override of existing method 'close' found for 'Ext.window.Window'. 327 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/HelpWindow.js Override of existing method 'close' found for 'Ext.window.Window'. 75 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/utils/EnhancedSlider.js Override of existing method 'getRawValue' found for 'Ext.slider.Single'. 67 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/image/ImageViewer.js Override of existing method 'onMouseDown' found for 'Ext.Component'. 568 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/search/SearchWindow.js Override of existing method 'close' found for 'Ext.window.Window'. 126 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/MeasureBasedView.js Override of existing method 'onSpinDown' found for 'Ext.form.Spinner'. 794 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/app/view/window/source/MeasureBasedView.js Override of existing method 'onSpinUp' found for 'Ext.form.Spinner'. 781 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/desktop/Wallpaper.js Override of existing method 'applyState' found for 'Ext.Component'. 32 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/desktop/Wallpaper.js Override of existing method 'getState' found for 'Ext.Component'. 40 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/grid/filter/Filter.js Override of existing method 'destroy' found for 'Ext.util.Observable'. 98 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/grid/FiltersFeature.js Override of existing method 'destroy' found for 'Ext.grid.feature.Feature'. 398 5
[ ] Warning @sencha/extjs/no-existing-method-override /Volumes/VCS/GitHub/Edirom/Edirom-Online/ext-ux/grid/menu/ListMenu.js Override of existing method 'destroy' found for 'Ext.Component'. 87 5

hizclick added a commit that referenced this issue May 16, 2024
@hizclick
Resolving issue #375 Error 'Call to removed method 'type' found for '…
9c853e7 
…Ext'' replace type with typeOf
@daniel-jettka daniel-jettka modified the milestones: Release v1.0.0-beta.6 (ExtJS upgrade), 1.0.0-beta.6 Jun 3, 2024
@bwbohl
Copy link
Member

bwbohl commented Jun 3, 2024 •
edited
Loading

ExtJS published GPL versions seem to have been:

  • 4.2.1-gpl
  • 5.1.0-gpl
  • 6.2.0-gpl
  • 7.0.0-gpl

@bwbohl
Copy link
Member

bwbohl commented Jun 5, 2024

While upgrading the browser, the error log should be checked to see if the error reported in #191 is being fixed.

@bwbohl
Copy link
Member

bwbohl commented Jun 11, 2024

The URI-scheme for downloading the GPL version from sencha is:

https://cdn.sencha.com/ext/gpl/ext-[MAJOR.MINOR.PATCH]-gpl.zip

e.g.

https://cdn.sencha.com/ext/gpl/ext-7.0.0-gpl.zip

@bwbohl bwbohl moved this to New in Edirom Development Jun 26, 2024
@krHERO krHERO moved this from New to In Progress in Edirom Development Jul 3, 2024
@krHERO krHERO modified the milestones: 1.0.0-beta.6, 1.1.0 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-jettka daniel-jettka

@hizclick hizclick

Labels
Area: Build & deploy Area: JS Status: needs work
Projects
Edirom Development
Status: In Progress
Milestone
1.1.0
Development

When branches are created from issues, their pull requests are automatically linked.

feature/extJS-7 Edirom/Edirom-Online
6 participants
@peterstadler @bwbohl @nikobeer @krHERO @daniel-jettka @hizclick