Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check getAnnotation.xql #163

Open
bwbohl opened this issue Jan 18, 2022 · 3 comments
Open

check getAnnotation.xql #163

bwbohl opened this issue Jan 18, 2022 · 3 comments

Comments

@bwbohl
Copy link
Member

bwbohl commented Jan 18, 2022

(<h1>{annotation:getLocalizedTitle($annot)}</h1>,

annotation:getLocalizedTitle($annot)

vs

eutil:getLocalizedName($annot, $lang)

@bwbohl
Copy link
Member Author

bwbohl commented Jan 18, 2022

                    if($annot/mei:annot)
                    then(
                        for $a in $annot/mei:annot
                        return
                            (<h1>{annotation:getLocalizedTitle($annot)}</h1>,
                            annotation:getContent($a,'', $edition))
                    )
                    else(
                        (<h1>{annotation:getLocalizedTitle($annot)}</h1>,
                        annotation:getContent($annot,'', $edition))
                    )
                }     

vs

           <h1>{eutil:getLocalizedName($annot, $lang)}</h1>
                {annotation:getContent($annot,'')}

@bwbohl bwbohl added this to the refactoring milestone Jun 17, 2022
@krHERO krHERO moved this to Backlog in Edirom Development Jul 3, 2024
@krHERO krHERO removed this from the refactoring milestone Jul 4, 2024
@bwbohl bwbohl added this to the 1.0.0 milestone Sep 6, 2024
@peterstadler
Copy link
Member

What is this exactly about? Is the idea to replace the function local:getLocalizedTitle($node) from getAnnotation.xql with some other function from the util or annotation module?

@bwbohl
Copy link
Member Author

bwbohl commented Oct 9, 2024

@peterstadler Yes that’s what it’s about, or at least check where the local function diverges from the one in eutil, whether they can be merged or not. This could be relevant for @riedde in the context of #311.

@bwbohl bwbohl modified the milestones: 1.0.0, 1.1.0 Dec 4, 2024
@krHERO krHERO modified the milestones: 1.1.0, 1.2.0 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants