Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit eutil:getLocalizedName #162

Closed
bwbohl opened this issue Jan 18, 2022 · 3 comments
Closed

revisit eutil:getLocalizedName #162

bwbohl opened this issue Jan 18, 2022 · 3 comments

Comments

@bwbohl
Copy link
Member

bwbohl commented Jan 18, 2022

What if the $node contains localised variants, this function would return both, wouldn't it?
Shouldn't there be a more general fallback first, e.g. something like:

Probably it should be clarified that not the node's but it's child nodes' values will be returned?

what string?

feel free to add @author

@bwbohl
Copy link
Member Author

bwbohl commented Jul 27, 2022

probably also rename util.xqm file from to eutil.xqm for consistency's sake.

@krHERO krHERO moved this to New in Edirom Development Jul 3, 2024
@krHERO krHERO removed this from the refactoring milestone Jul 4, 2024
@bwbohl bwbohl added this to the 1.0.0 milestone Sep 6, 2024
@bwbohl bwbohl moved this from New to Backlog in Edirom Development Oct 9, 2024
@riedde
Copy link
Contributor

riedde commented Oct 9, 2024

@riedde See also #311 #103 (PR #426), when revisiting

@bwbohl
Copy link
Member Author

bwbohl commented Dec 4, 2024

For 1.0.0 test in context of #426 close if fixed else push

@bwbohl bwbohl self-assigned this Dec 4, 2024
@riedde riedde closed this as completed Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Edirom Development Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants