You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
boolpublic_key::is_canonical( const compact_signature& c ) {
For canonical signature checks most standard ec libraries only enforce a low_s however the code referenced in this issue is enforcing a low_r (r being less than half of the curve order) as well. I'm wondering why that check is needed? Checking low_s should be enough to protect against signature malleability.
A clarification on why a low_r is being checked would be greatly appreciated, and if there is no need for it can that check be removed?
The text was updated successfully, but these errors were encountered:
islamaminBitGo
changed the title
Canonical EC signature check might be unnecessary.
Canonical EC signature check against r value in the signature might be unnecessary.
Jul 18, 2024
fc/src/crypto/elliptic_common.cpp
Line 161 in ff56d25
For canonical signature checks most standard ec libraries only enforce a low_s however the code referenced in this issue is enforcing a low_r (r being less than half of the curve order) as well. I'm wondering why that check is needed? Checking low_s should be enough to protect against signature malleability.
A clarification on why a low_r is being checked would be greatly appreciated, and if there is no need for it can that check be removed?
The text was updated successfully, but these errors were encountered: