Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical EC signature check against r value in the signature might be unnecessary. #238

Open
islamaminBitGo opened this issue Jul 18, 2024 · 0 comments

Comments

@islamaminBitGo
Copy link

islamaminBitGo commented Jul 18, 2024

bool public_key::is_canonical( const compact_signature& c ) {

For canonical signature checks most standard ec libraries only enforce a low_s however the code referenced in this issue is enforcing a low_r (r being less than half of the curve order) as well. I'm wondering why that check is needed? Checking low_s should be enough to protect against signature malleability.

A clarification on why a low_r is being checked would be greatly appreciated, and if there is no need for it can that check be removed?

@islamaminBitGo islamaminBitGo changed the title Canonical EC signature check might be unnecessary. Canonical EC signature check against r value in the signature might be unnecessary. Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant