TriggerConnections() does not terminate?

[troglobit]

Hi,

am I missing something in this function, or is it missing a node = node->next; at the end of the while() loop?

If the first open connection doesn't match the output or input assembly arguments to the function we seem to be spinning forever on the first node. Right?

OpENer/source/src/cip/cipconnectionmanager.c

Lines 1694 to 1716 in 329b231

	EipStatus TriggerConnections(unsigned int output_assembly,
	unsigned int input_assembly) {
	EipStatus status = kEipStatusError;
	DoublyLinkedListNode *node = connection_list.first;
	while(NULL != node) {
	CipConnectionObject *connection_object = node->data;
	if( (output_assembly == connection_object->consumed_path.instance_id) &&
	(input_assembly == connection_object->produced_path.instance_id) ) {
	if(
	kConnectionObjectTransportClassTriggerProductionTriggerApplicationObject
	== ConnectionObjectGetTransportClassTriggerProductionTrigger(
	connection_object) ) {
	/* produce at the next allowed occurrence */
	connection_object->transmission_trigger_timer =
	connection_object->production_inhibit_time;
	status = kEipStatusOk;
	}
	break;
	}
	}
	return status;
	}

[MartinMelikMerkumians]

Hi,

shame on me. Yes seems an oversight by me. Guess that code has never been used in any tests 😅

[troglobit]

OK, I can send a PR later today to fix it.