From 324a228e8abfdf6527fa3ea401cb0050000e796e Mon Sep 17 00:00:00 2001 From: ablanathtanalba Date: Wed, 28 Jul 2021 14:37:56 -0700 Subject: [PATCH 1/5] added i18n messages for widgets section in popup --- src/_locales/en_US/messages.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/_locales/en_US/messages.json b/src/_locales/en_US/messages.json index 93c4d9e083..d53efa94fa 100644 --- a/src/_locales/en_US/messages.json +++ b/src/_locales/en_US/messages.json @@ -445,6 +445,14 @@ } } }, + "popup_info_replaced_widgets": { + "message": "Some widgets have been temporarily replaced", + "description": "Clickable status header text in the popup. Shown when a media widget like Spotify embed or Disqus comment section has been temporarily replaced by Privacy Badger with a click-to-activate placeholder." + }, + "popup_info_widgets_description": { + "message": "Some embedded content on this page might be used to track you, so Privacy Badger has temporarily replaced them. You can click to activate them here or on the page itself.", + "description": "Clickable status header text in the popup. Shown when a media widget like Spotify embed or Disqus comment section has been temporarily replaced by Privacy Badger with a click-to-activate placeholder." + }, "popup_instructions": { "message": "$COUNT$ potential $LINK_START$trackers$LINK_END$ blocked", "description": "Popup message shown when at least one tracker was blocked.", From 4ffad9df5f27fce81ce0a02e2a712829406abf7a Mon Sep 17 00:00:00 2001 From: ablanathtanalba Date: Wed, 28 Jul 2021 14:42:23 -0700 Subject: [PATCH 2/5] template for widgets section in popup using extant html and css --- src/skin/popup.css | 10 +++++++--- src/skin/popup.html | 13 +++++++++++++ 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/skin/popup.css b/src/skin/popup.css index b811dd412e..0d00fe7b00 100644 --- a/src/skin/popup.css +++ b/src/skin/popup.css @@ -303,7 +303,7 @@ body#main #pbInstructions a, #firstparty-protections-container a, #webrtc-deprec body#main #pbInstructions a:hover, #firstparty-protections-container a:hover, #webrtc-deprecation-div a:hover, #donate a:hover { color: #ec9329; } -#instructions-firstparty-description { +#instructions-firstparty-description, #instructions-widgets-description { font-size: 14px; background-color: #e8e9ea; color: #555; @@ -476,6 +476,10 @@ div.overlay.active { margin: 10px 0; padding-bottom: 5px; } +#replaced-widgets-container { + border-bottom: 1px solid #d3d3d3; + padding-bottom: 5px; +} .basic-header { text-align: center; margin: 15px 0; @@ -582,7 +586,7 @@ div.overlay.active { color: #fff; } - #firstparty-protections-container { + #firstparty-protections-container, #replaced-widgets-container { border-bottom: 1px solid #555; } @@ -618,7 +622,7 @@ div.overlay.active { background-color: #3a3a3a; } - #instructions-firstparty-description { + #instructions-firstparty-description, #instructions-widgets-description { background-color: #3a3a3a; color: #ddd; } diff --git a/src/skin/popup.html b/src/skin/popup.html index e70393baaa..0cd636c6fe 100644 --- a/src/skin/popup.html +++ b/src/skin/popup.html @@ -144,6 +144,19 @@

+ +