Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Term missing in Paasch impedance T(p,f)? #251

Open
mathijsajanssen opened this issue Feb 18, 2023 · 1 comment
Open

Term missing in Paasch impedance T(p,f)? #251

mathijsajanssen opened this issue Feb 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mathijsajanssen
Copy link

It seems to me that the element T(p,f) is supposed to model Eq. 22 from Paasch et al.'s paper, and that the last term of that equation is lacking on line 380 from elements.py.
I think an additional +B/2 may be needed on that line.
@mathijsajanssen mathijsajanssen added the bug Something isn't working label Feb 18, 2023
mdmurbach added a commit to mdmurbach/impedance.py that referenced this issue Feb 20, 2023
@mdmurbach
adds B/2 term to Paasch element, fixes ECSHackWeek#251
5ed337b
@mdmurbach
Copy link
Member

Thanks for the catch and for filing an Issue report :) Added a PR fixing this here: #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdmurbach @mathijsajanssen