EAMXX: add a DataInterpolation class #6812
Draft
+1,105
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartgol
added
EAMxx
|
bartgol
force-pushed
the
bartgol/eamxx/data-interpolation
branch
2 times, most recently
from
d6d24a8 to
261933d
Compare
Simplifies some operations that looked clunky on the client end
* The class handles time, horizontal, and vertical interpolation * The vertical/horizontal are optional, but the time dimension is REQUIRED
bartgol
force-pushed
the
bartgol/eamxx/data-interpolation
branch
from
261933d to
eb23fd7
Compare
bartgol
force-pushed
the
bartgol/eamxx/data-interpolation
branch
from
eb23fd7 to
6bfbb0f
Compare
We may not have any mid or any int field. No need to force us to create a valid field just for passing checks.
AaronDonahue
reviewed
Dec 9, 2024
| * and allows two things: compute the interval length (in days), and check if | ||
| * a timestamp lies within the interval. | ||
| * | ||
| * When te TimeLine arg to the ctor is YearlyPeriodic, the year part of beg/end |
I don't think so. The three interpolations are tightly coupled via remappers. Sure, the remapper can be For reviewers: I try to isolate concepts into their own commits. So one way to make reviews easier is to review one commit at a time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class is in charge of reading in time-dependent datasets from input file(s), interpolate to current model time, and possibly do horizontal/vertical interpolation
The implementation is not yet complete, but some early thoughts on whether we're on the right track or not may help. Besides, getting some early testing on ghci machines can also help.
Things left to do:
I am NOT implementing a data interpolation for variables without a time dependence. It simply reduces to constructing 2 remappers, and since non-time dep data is most likely load-able at init, there's no real need for a complex data structure. Time interpolation is the most tricky of the 3 anyways, due to the different needs (nudging uses Linear timeline, while SPA uses a YearlyPeriodic one)
For reviewers: i recommend reviewing one commit at a time. That would help isolate concepts, so you can hopefully better follow. The hardest thing to review is the data interpolation unit tests, since there is quite a bit of code needed to generate cases that we can manually check without redoing the same operation as the interpolation class (copy+paste of src code in tests folder doesn't help).
Fixes #6810
Fixes #6820