EAMxx: Change default value of lambda_high in SHOC to 0.08 #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogensch
added
non-BFB
bogensch
changed the title
|
|
I can approve, but only based on the fact that this is the setting we've been using for all SCREAM production cases. |
|
Will need to be tested overnight on next before merging to master. |
|
Since this PR touches |
|
I ran all of the scream tests I found in our testing python script on both pm-cpu and pm-gpu. All GNU tests pass as expected. With Intel on pm-cpu, there are some fails, but they are known and unrelated to this change (with issues created). |
|
What other testing is good for this change? |
ndkeen
approved these changes
Dec 6, 2024
|
@rljacob do you want to assign an integrator for this PR? |
bartgol
approved these changes
Dec 10, 2024
|
@bogensch Does it make sense that the DP scream test PASSed while the other ones DIFFed? |
|
@bartgol it actually does, because the case being tested is ARM97 which is a convective/unstable case. This means that values of lambda (stability parameter) will always be on the low end (close to lambda_low). Values only approach the lambda_high values for more stratiform regimes. Just did a sanity test for a DPxx case where I would expect this parameter modification to have an impact (DYCOMS-RF01) and the solution there is different, as expected. |
|
@rljacob I see an email from yesterday saying NEXT is open, is that still the case? What is the best way to find the status of NEXT? |
|
Best way is to ask in the #infrastructure-devops channel on Slack. Its open today. |
tcclevenger
added a commit
that referenced
this pull request
Dec 11, 2024
…6797) This "new" value of 0.08 for lambda_high for SHOC has been used in all recent SCREAM production runs (CESS experiments; decadal) but for some reason was never made default in master. Correcting that here. Modified from 0.04 to 0.08 because this improves the representation of marine stratocumulus. [non-BFB]
|
Merged to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "new" value of 0.08 for lambda_high for SHOC has been used in all recent SCREAM production runs (CESS experiments; decadal) but for some reason was never made default in master. Correcting that here. Modified from 0.04 to 0.08 because this improves the representation of marine stratocumulus.
DIFFs are expected.