Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FATES API update for SPITFIRE refactor #6762

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

FATES API update for SPITFIRE refactor #6762

wants to merge 3 commits into from

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Nov 21, 2024 •
edited
Loading

Updates fates to API37 per a fates-side fire refactor which renames and moves nfsc. This updates the fates tag with a number of fates-side fixes and feature updates so fates tests will be answer changing.

This also fixes #6806

[non-B4B] for fates tests

@glemieux
FATES API update to capture fuel class refactor
da584a6 
This commit updates fates to API37 which is necessary to capture
renaming per a fates-side fire refactor
@glemieux glemieux added the FATES label Nov 21, 2024
@glemieux glemieux changed the title FATES API update to capture fuel class refactor FATES API update for fuel class refactor Nov 21, 2024
@glemieux glemieux changed the title FATES API update for fuel class refactor FATES API update for SPITFIRE refactor Nov 21, 2024
@rljacob rljacob added the elm land model label Nov 21, 2024
@glemieux
Copy link
Contributor Author

Regression testing against e3sm_land_developer baseline underway on perlmutter.

@bishtgautam bishtgautam self-requested a review November 28, 2024 03:47
@glemieux
Copy link
Contributor Author

glemieux commented Dec 2, 2024

Regression testing on perlmutter with the e3sm_land_developer suite against the master baseline is complete. Test results are b4b for all non-fates tests as expected. FATES diffs are showing up with very low differences against baseline (i.e. E-23) for FATES_CBALANCE_ERROR and FATES_ERROR_EL.

This is good to integrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishtgautam bishtgautam bishtgautam approved these changes

Assignees

@bishtgautam bishtgautam

Labels
elm land model FATES
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ELM-FATES harvest mode option character length is too short
3 participants
@glemieux @bishtgautam @rljacob