-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAMxx: (MAM4xx) Adds gas dry deposition call in aerosol microphysics #6751
Draft
overfelt
wants to merge
91
commits into
E3SM-Project:master
Choose a base branch
from
overfelt:jroverf/mam4_perform_atmospheric_chemistry_and_microphysics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
EAMxx: (MAM4xx) Adds gas dry deposition call in aerosol microphysics #6751
overfelt
wants to merge
91
commits into
E3SM-Project:master
from
overfelt:jroverf/mam4_perform_atmospheric_chemistry_and_microphysics
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overfelt
force-pushed
the
jroverf/mam4_perform_atmospheric_chemistry_and_microphysics
branch
from
November 18, 2024 18:48
e344e01
to
3dc94f2
Compare
singhbalwinder
changed the title
Implement call to mam4xx::perform_atmospheric_chemistry_and_microphyics
EAMxx: (MAM4xx) Adds gas dry deposition call in aerosol microphysics
Nov 22, 2024
Is this PR BFB or not? |
@rljacob , No these changes are not expected to be bit-for-bit as dry-deposition was not really working correctly before. @singhbalwinder is making quite a few changes to fix it. |
overfelt
force-pushed
the
jroverf/mam4_perform_atmospheric_chemistry_and_microphysics
branch
from
November 22, 2024 21:37
8023428
to
ee50c58
Compare
…kos profiling output.
…we spend in deep copy.
singhbalwinder
force-pushed
the
jroverf/mam4_perform_atmospheric_chemistry_and_microphysics
branch
from
November 23, 2024 06:29
ee50c58
to
3e55254
Compare
* Use RelWithDebInfo to compromise speed and analysis * Limit number of OMP threads to 2
We were missing the gator initial mb env var
* Changed from Core/24.07 to Core/24.00 * Changed from cmake/3.27.9 to cmake/3.21.3 * Restored '--allow-shlib-undefined --allow-multiple-definition' in CMAKE_EXE_LINKER_FLAGS * Removed 'craype-accel-amd-gfx90a' module load for amdclanggpu_frontier * Added two mosart source files into NOOPT_FILES to workaround to prevent optcg crayclanggpu build error
Modify pe layouts for v3 prod cases for anvil
Adds Commented out code to stage next changes Adds aerosol fields as required and also in the input yaml xsx# This is a combination of 9 commits. Adds cloud borne aerosols; fixes a minor bug in mam coupling Adds all input output variables in set grid Just stashing a working version. General code clean up by using structs from mam_coupling.hpp Fix accidental push of wrong file. Fixes for Cuda compiler. Requires latest mam4xx to work. Create CNT_couple C++ from Fortran version. Add logic for SIMD data types. EAMxx:Cleaned up some files after rebase of this old branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An existing EAMxx interface (eamxx_mam_microphysics_process_interface.cpp) is modified to include the invocation of the dry deposition for gases.
Since the CMake option, SCREAM_ENABLE_MAM, is always ON, these codes are always compiled with the EAMxx codebase, but this interface can be turned off/on using the namelist flags.
[non-BFB] for EAMxx cases
Output variables
This process computes dry deposition fluxes (
dflx
) that are used to update constituent_fluxes.Testing
We have existing tests for this interface, so we didn't add any new tests. We have a suite of validation tests in the MAM4xx repo to validate sethet process
The
atmchange
command to invoke this process in a CIME simulation is:./atmchange physics::atm_procs_list="mac_aero_mic,rrtmgp,mam4_aero_microphys
To set up a test with the above configuration, use the following commands:
Where,
<machine>
is the machine name<compiler>
is the compiler to use on the machine<test id >
is a unique string test identifier<project id>
is the allocation project to chargescream-mam4xx-aero_microphysics
is the test modifier that addsmam4_aero_microphys
to theatm_procs_list
process list and increases the number of tracers to 41.For
ne30pg2
grid, use the following command:New input data
No new input data
Figures from model analysis
Coming soon
Standalone Test Timings (Compy):
We will upload the timings once the PR is reviewed and approved