EAMXX: fix misc compiler warnings

E3SM-Project · Dec 6, 2024 · 6bfbb0f · 6bfbb0f
1 parent 9314ed6
commit 6bfbb0f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/components/eamxx/src/dynamics/homme/interface/homme_context_mod.F90 b/components/eamxx/src/dynamics/homme/interface/homme_context_mod.F90
@@ -168,37 +168,37 @@ end subroutine init_parallel_f90
   function is_parallel_inited_f90 () result(inited) bind(c)
     logical (kind=c_bool) :: inited
 
-    inited = is_parallel_inited
+    inited = LOGICAL(is_parallel_inited,kind=c_bool)
   end function is_parallel_inited_f90
 
   function is_params_inited_f90 () result(inited) bind(c)
     logical (kind=c_bool) :: inited
 
-    inited = is_params_inited
+    inited = LOGICAL(is_params_inited,kind=c_bool)
   end function is_params_inited_f90
 
   function is_geometry_inited_f90 () result(inited) bind(c)
     logical (kind=c_bool) :: inited
 
-    inited = is_geometry_inited
+    inited = LOGICAL(is_geometry_inited,kind=c_bool)
   end function is_geometry_inited_f90
 
   function is_data_structures_inited_f90 () result(inited) bind(c)
     logical (kind=c_bool) :: inited
 
-    inited = is_data_structures_inited
+    inited = LOGICAL(is_data_structures_inited,kind=c_bool)
   end function is_data_structures_inited_f90
 
   function is_model_inited_f90 () result(inited) bind(c)
     logical (kind=c_bool) :: inited
 
-    inited = is_model_inited
+    inited = LOGICAL(is_model_inited,kind=c_bool)
   end function is_model_inited_f90
 
   function is_hommexx_functors_inited_f90 () result(inited) bind(c)
     logical (kind=c_bool) :: inited
 
-    inited = is_hommexx_functors_inited
+    inited = LOGICAL(is_hommexx_functors_inited,kind=c_bool)
   end function is_hommexx_functors_inited_f90
 
 end module homme_context_mod
diff --git a/components/eamxx/src/physics/shoc/tests/shoc_pdf_thl_parameters_tests.cpp b/components/eamxx/src/physics/shoc/tests/shoc_pdf_thl_parameters_tests.cpp
@@ -50,8 +50,6 @@ struct UnitWrap::UnitTest<D>::TestShocThlParameters {
     static constexpr Real Skew_w_test1 = 3;
     // Define fraction of first gaussian
     static constexpr Real a_test1 = 0.2;
-    // Define logical
-    static constexpr bool dothetal_skew = false;
 
     // Define reasonable bounds checking for output
     static constexpr Real thl_bound_low = 200; // [K]