From 41d89122382574df55d83da391437c078a020f3b Mon Sep 17 00:00:00 2001 From: pinzart90 <46732933+pinzart90@users.noreply.github.com> Date: Thu, 6 Feb 2025 17:22:34 -0500 Subject: [PATCH] DYN-8268: fix noNetworkMode for PM client (#15809) --- src/DynamoPackages/PackageManagerClient.cs | 4 +--- src/DynamoPackages/PackageManagerExtension.cs | 10 +++++++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/DynamoPackages/PackageManagerClient.cs b/src/DynamoPackages/PackageManagerClient.cs index 244854cf8f7..5d672337e32 100644 --- a/src/DynamoPackages/PackageManagerClient.cs +++ b/src/DynamoPackages/PackageManagerClient.cs @@ -57,8 +57,6 @@ internal PackageManagerClient(IGregClient client, IPackageUploadBuilder builder, this.uploadBuilder = builder; this.client = client; this.packageMaintainers = new Dictionary(); - - this.LoadCompatibilityMap(); // Load the compatibility map } internal bool Upvote(string packageId) @@ -370,7 +368,7 @@ internal static Dictionary> GetCompatibilityM /// /// Method to load the map once, making it accessible to all elements /// - private void LoadCompatibilityMap() + internal void LoadCompatibilityMap() { if (compatibilityMap == null) // Load only if not already loaded { diff --git a/src/DynamoPackages/PackageManagerExtension.cs b/src/DynamoPackages/PackageManagerExtension.cs index a97c30d3ab5..3c3bf454b28 100644 --- a/src/DynamoPackages/PackageManagerExtension.cs +++ b/src/DynamoPackages/PackageManagerExtension.cs @@ -161,8 +161,16 @@ public void Startup(StartupParams startupParams) new GregClient(startupParams.AuthProvider, url), uploadBuilder, packageUploadDirectory); - LoadPackages(startupParams.Preferences, startupParams.PathManager); noNetworkMode = startupParams.NoNetworkMode; + + //we don't ask dpm for the compatibility map in offline mode. + if (!noNetworkMode) + { + // Load the compatibility map + PackageManagerClient.LoadCompatibilityMap(); + } + + LoadPackages(startupParams.Preferences, startupParams.PathManager); } ///