Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Typage LOG.warning: Return type #66

Open
xDesignX opened this issue Jan 11, 2023 · 1 comment
Open

Update Typage LOG.warning: Return type #66

xDesignX opened this issue Jan 11, 2023 · 1 comment

Comments

@xDesignX
Copy link

    public function getIterator()
    {
        return new ArrayIterator($this->items);
    }

 LOG.warning: Return type of Dymantic\InstagramFeed\InstagramFeed::getIterator()

    public function count()
    {
        return count($this->items);
    }

LOG.warning: Return type of Dymantic\InstagramFeed\InstagramFeed::count() should either be compatible with Countable::count(): int,


TO

   public function getIterator() : ArrayIterator
    {
        return new ArrayIterator($this->items);
    }

    public function count() : Int
    {
        return count($this->items);
    }

Can you update the function ?

Thank You for your instagram module

@vigorjs
Copy link

vigorjs commented Aug 27, 2023

i also facing the same problem :(
error log :
DEPRECATED Return type of Dymantic\InstagramFeed\InstagramFeed::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor\dymantic\laravel-instagram-feed\src\InstagramFeed.php on line 42.

DEPRECATED Return type of Dymantic\InstagramFeed\InstagramFeed::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor\dymantic\laravel-instagram-feed\src\InstagramFeed.php on line 47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants