Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Feedback! #1

Open
codepathreview opened this issue Jul 9, 2018 · 0 comments
Open

Project Feedback! #1

codepathreview opened this issue Jul 9, 2018 · 0 comments

Comments

@codepathreview
Copy link

👍 excellent work. A few notes after checking out the code:

  • Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
  • Good use of string resources for text values
  • Consider adding better input validation and user feedback if values are invalid or empty
  • Consider adding progress bars to your app whenever a network request goes out
  • Consider including a check to see if internet is available to detect any network failures. Show an appropriate message in case of failure.
  • Good to see you playing around with RelativeLayout. RelativeLayout is one of the most powerful responsive-first layout systems available across web and mobile platforms and provides better control in comparison to a linear layout.
  • Good job using the ViewHolder pattern to improve performance of photos ListView.
  • Great work on using a placeholder graphic during loading.
  • Please finalize the YouTubePlayerView in the future.
  • Good job using the [ButterKnife library annotations] (http://guides.codepath.com/android/Reducing-View-Boilerplate-with-Butterknife) for declaring handles to view objects.

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us [email protected].

P.S. Good to see you properly added the README with features and screenshots to your project as described in the submitting assignments guide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant