Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:添加chown系统调用 #962

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

feat:添加chown系统调用 #962

wants to merge 17 commits into from

Conversation

sparkzky
Copy link
Contributor

@sparkzky sparkzky commented Oct 10, 2024 •
edited
Loading

原942号pr
#942

添加chown系列的系统调用，获取inode后修改uid和gid信息。

@dragonosbot
Copy link

感谢您的pull request，欢迎加入！🎉 DragonOS社区很兴奋地期待审核您的更改，您将在接下来的两周内收到 @fslongjin @GnoCiYeH @Chiichen (NB. this repo may be misconfigured) 的回复。💬😊

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-等待审查 and S-等待作者修改) stays updated, invoking these commands when appropriate:

  • @dragonosbot author: 审查结束后，PR的作者应检查评论并采取相应行动
  • @dragonosbot review: 作者已完成修改，将此PR提交给reviewer进行审阅，此PR将再次在审阅者队列中排队

@dragonosbot dragonosbot added A-fs Area: 文件系统 S-等待审查 Status: 等待assignee以及相关方的审查。 labels Oct 10, 2024
@github-actions github-actions bot added ambiguous The title of PR/issue doesn't match the format documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 10, 2024
@sparkzky sparkzky changed the title Patch-chown feat:添加chown系统调用 Oct 10, 2024
@github-actions github-actions bot added enhancement New feature or request and removed ambiguous The title of PR/issue doesn't match the format labels Oct 10, 2024
fslongjin
fslongjin requested changes Oct 12, 2024
View reviewed changes
Copy link
Member

@fslongjin fslongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要更改
@dragonosbot author

kernel/src/filesystem/vfs/open.rs Outdated Show resolved Hide resolved
kernel/src/filesystem/vfs/open.rs Outdated Show resolved Hide resolved
kernel/src/filesystem/vfs/open.rs Outdated Show resolved Hide resolved
user/apps/test-chown/src/main.rs Show resolved Hide resolved
@dragonosbot dragonosbot added S-等待作者修改 Status: 这正在等待作者的一些操作（例如代码更改或更多信息）。 and removed S-等待审查 Status: 等待assignee以及相关方的审查。 labels Oct 12, 2024
@dragonosbot dragonosbot added A-driver Area: 驱动程序 T-doc Relevant to the document team, which will review and decide on the PR/issue. labels Oct 14, 2024
@dragonosbot
Copy link

tty驱动发生了更改，请进行审查

cc @GnoCiYeH

@fslongjin
Copy link
Member

合并主线内容进来的时候选择用merge的方式，不然会造成很多更改。

@sparkzky
Copy link
Contributor Author

已经跑过make fmt了

@fslongjin
Copy link
Member

函数注释的格式要改一下，详细的要参考文档里面参与开发部分有讲注释格式

fslongjin
fslongjin reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@fslongjin fslongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragonosbot author

kernel/src/filesystem/vfs/mod.rs Outdated
Comment on lines 681 to 688
/// @brief 查找文件（考虑符号链接，并且考虑是否返回最终路径的符号链接文件本身）
///
/// @param path 文件路径
/// @param max_follow_times 最大经过的符号链接的大小
/// @follow_final_symlink: 是否跟随最后的符号链接
///
/// @return Ok(Arc<dyn IndexNode>) 要寻找的目录项的inode
/// @return Err(SystemError) 错误码
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释风格参考
https://docs.dragonos.org.cn/community/code_contribution/rust-coding-style.html#id6

fslongjin
fslongjin requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@fslongjin fslongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragonosbot author

kernel/src/filesystem/vfs/mod.rs Outdated Show resolved Hide resolved
kernel/src/filesystem/vfs/mod.rs Outdated Show resolved Hide resolved
kernel/src/syscall/mod.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fslongjin fslongjin fslongjin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-driver Area: 驱动程序 A-fs Area: 文件系统 enhancement New feature or request S-等待作者修改 Status: 这正在等待作者的一些操作（例如代码更改或更多信息）。 T-doc Relevant to the document team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sparkzky @dragonosbot @fslongjin