Skip to content

Commit b16a789

Browse files
committed
Mypy, formatting and deleting unused modules
minor fixes
1 parent 806c0fe commit b16a789

File tree

7 files changed

+20
-22
lines changed

7 files changed

+20
-22
lines changed

jsb/lib/boot.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -487,8 +487,12 @@ def savecallbacktable(modname=None):
487487
target = LazyDict(callbacktable.data)
488488
else:
489489
target = LazyDict()
490-
from jsb.lib.callbacks import (callbacks, first_callbacks, last_callbacks,
491-
remote_callbacks)
490+
from jsb.lib.callbacks import (
491+
callbacks,
492+
first_callbacks,
493+
last_callbacks,
494+
remote_callbacks,
495+
)
492496

493497
for cb in [first_callbacks, callbacks, last_callbacks, remote_callbacks]:
494498
for type, cbs in cb.cbs.items():
@@ -510,8 +514,12 @@ def removecallbacks(modname):
510514
"""remove callbacks belonging to modname form cmndtable."""
511515
global callbacktable
512516
assert callbacktable
513-
from jsb.lib.callbacks import (callbacks, first_callbacks, last_callbacks,
514-
remote_callbacks)
517+
from jsb.lib.callbacks import (
518+
callbacks,
519+
first_callbacks,
520+
last_callbacks,
521+
remote_callbacks,
522+
)
515523

516524
for cb in [first_callbacks, callbacks, last_callbacks, remote_callbacks]:
517525
for type, cbs in cb.cbs.items():

jsb/lib/commands.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,10 @@ class Commands(LazyDict):
8484
8585
"""
8686

87-
regex = []
87+
regex: typing.List[str] = []
88+
89+
def __init__(self):
90+
LazyDict.__init__(self)
8891

8992
def add(
9093
self,

jsb/lib/errors.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,6 @@ class CantSaveConfig(JsonBotError):
9090
pass
9191

9292

93-
class NoOwnerSet(JsonBotError):
94-
pass
95-
96-
9793
class NameNotSet(JsonBotError):
9894
pass
9995

jsb/lib/exit.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
# jsb imports
88

9-
import atexit
109
import logging
1110
import os
1211
import sys
@@ -15,11 +14,9 @@
1514
from jsb.lib.boot import ongae
1615
from jsb.lib.persist import cleanup
1716
from jsb.memcached import killmcdaemon
18-
from jsb.utils.exception import handle_exception
1917
from jsb.utils.locking import globallocked
20-
from jsb.utils.trace import whichmodule
2118

22-
from .runner import callbackrunner, cmndrunner, defaultrunner, waitrunner
19+
from .runner import callbackrunner, cmndrunner, waitrunner
2320

2421
# basic imports
2522

jsb/plugs/common/bugtracker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class BugTrackerNotSupported(Exception):
5858

5959
class BugTracker:
6060

61-
bugurls = [] # regexp patterns that could match a bugtracker url
61+
bugurls: typing.List[str] = [] # regexp patterns that could match a bugtracker url
6262
bugtags = re.compile("(?:bug|ticket)*\s?#(\d+)", re.I)
6363

6464
def __init__(self, baseUrl, autoshow):
@@ -621,7 +621,7 @@ class BugManager(Pdod):
621621
"mantis": Mantis,
622622
"trac": Trac,
623623
}
624-
instances = {}
624+
instances: typing.Dict[str, typing.Dict[str, BugTracker]] = {}
625625

626626
def __init__(self):
627627
Pdod.__init__(

jsb/plugs/common/rss.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -942,13 +942,6 @@ def clone(self, botname, bottype, newchannel, oldchannel):
942942

943943
assert watcher
944944

945-
# size function
946-
947-
948-
def size():
949-
return "%s (feeds)" % watcher.size()
950-
951-
952945
# dosync function
953946

954947

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[tool.black]

0 commit comments

Comments
 (0)