-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heartbeat is not working anymore #148
Comments
I can approve, heartbeat is not working. Response from readContents method: Server inaccessibility301 - Moved Permanently/ Request ID: 179059083 bg Сървърът е временно недостъпен
cs Server je dočasně nedostupný
da Serveren er midlertidigt utilgængelig
de Der Server ist vorübergehend nicht verfügbar
el Ο διακομιστής δεν είναι διαθέσιμος προσωρινά
en The server is temporarily unavailable
es El servidor no está disponible temporalmente
et Server ei ole ajutiselt kättesaadav
fi Palvelin on väliaikaisesti poissa käytöstä
fr Le serveur est temporairement indisponible
ga Níl fáil ar an bhfreastalaí i láthair na huaire
hr Poslužitelj je privremeno nedostupan
hu A szerver átmenetileg nem érhető el, kérjük, próbálkozzon újra később
it Il server è temporaneamente non disponibile
lt Serveris laikinai neveikia
lv Serveris pagaidām nav pieejams
mt Is-server mhux disponibbli temporanjament
nl De server is tijdelijk niet beschikbaar
pl Serwer jest tymczasowo niedostępny
pt O servidor está temporariamente indisponível
ro Serverul este temporar indisponibil
sk Server je dočasne nedostupný
sl Strežnik je začasno nedosegljiv
sv Servern är inte tillgänglig för tillfället
<script> svg4everybody({ polyfill: true }); </script> """ ] |
I too. No longer working anymore. |
We should monitor |
|
No i don't think the https://viesapi.eu/ is a original vies service? But just a company which builds a rest api on top of it? But about the heartbeat? I'm not really sure it is really needed, but if so than the "ec.europa.eu/taxation_customs/vies" would be better. I can give it a try maybe this weekend to create a merge request |
Yep it's a wrapper. A quick fix would be to add 301 header as a correct response - the same as 308 was added. |
Given it more thought, that even appears to be the better solution to me as the heartbeat is about host availability, right? |
Client-side question: Is there actually any good reason for doing this heartbeat check? What is the risk if we don't use it at all? If the service is down, the VAT check fails and you have an error anyway. |
Well @sophie-kuehn i don't use the heartbeat anymore and we just try catch the calls with a timeout. |
Pull Request #149 |
tested and it fixes the issue, thanks! |
If fixed, why is this issue still open? |
The heartbeat is calling tls://ec.europa.eu:443 but there has been a change on this website.
Now the status code is "HTTP/1.1 301 Moved Permanently" and the heartbeat is failing :
https://github.com/DragonBe/vies/blob/master/src/Vies/HeartBeat.php#L161
The text was updated successfully, but these errors were encountered: