Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class with finalizer should extend CriticalFinalizerObject #15

Open
sharwell opened this issue Nov 17, 2014 · 0 comments
Open

Class with finalizer should extend CriticalFinalizerObject #15

sharwell opened this issue Nov 17, 2014 · 0 comments
Labels
agnostic diagnostic

Comments

@sharwell
Copy link
Member

This is a straightforward diagnosic-only analyzer. Classes which include a user-defined finalizer should extend CriticalFinalizerObject (typically SafeHandle or CriticalHandle, or a class derived from one of those).

Since there are known exceptions to this guideline (e.g. Task), it should be reported only as a warning by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agnostic diagnostic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sharwell