Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INPC001: should not trigger for internal properties, since they are not bindable #171

Closed
Insire opened this issue Feb 9, 2020 · 3 comments

Comments

@Insire
Copy link

Insire commented Feb 9, 2020

grafik

@JohanLarsson
Copy link
Collaborator

Internal properties are bindable if they are in the application/exe project. We can detect that better. Maybe we should split out a separate rule if internal properties should notify to enable configuration.
For the stuff I write I often want internal to notify as I use them with rx and not only bindings.

@Insire
Copy link
Author

Insire commented Feb 10, 2020

Internal properties are bindable if they are in the application/exe project.

TIL.

But yeah, this is in a library project and that class should not be bound to.

@Insire
Copy link
Author

Insire commented Feb 10, 2020

I have a better suggestion/ preferable approach in #172 , so im closing this one.

@Insire Insire closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants