Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Don't provide code fixes for Visual Basic in UseConfigureAwaitCodeFixProvider and DontUseThreadSleepCodeUniversalCodeFixProvider #51

Closed
tmaczynski opened this issue Sep 11, 2016 · 0 comments
Closed

Don't provide code fixes for Visual Basic in UseConfigureAwaitCodeFixProvider and DontUseThreadSleepCodeUniversalCodeFixProvider #51

tmaczynski opened this issue Sep 11, 2016 · 0 comments
Assignees
@sharwell
Labels
fixed

Comments

@tmaczynski
Copy link
Contributor

tmaczynski commented Sep 11, 2016 •
edited
Loading

I think that Visual Basic should be deleted from ExportCodeFixProvider attributes in UseConfigureAwaitCodeFixProvider and DontUseThreadSleepCodeUniversalCodeFixProvider (from PR #50 ). Both code fixes use classes from Microsoft.CodeAnalysis.CSharp and Microsoft.CodeAnalysis.CSharp.Syntax and clearly won't fix Visual Basic code.
@tmaczynski tmaczynski changed the title Delete Don't provide code fixes for Visual Basic Sep 11, 2016
@tmaczynski tmaczynski changed the title Don't provide code fixes for Visual Basic Don't provide code fixes for Visual Basic in UseConfigureAwaitCodeFixProvider and DontUseThreadSleepCodeUniversalCodeFixProvider Sep 11, 2016
sharwell added a commit to sharwell/AsyncUsageAnalyzers that referenced this issue Jul 25, 2017
@sharwell
Remove VisualBasic from the languages supported by UseConfigureAwaitC…
ed0f501 
…odeFixProvider

Fixes DotNetAnalyzers#51
@sharwell sharwell mentioned this issue Jul 25, 2017
Merged
@sharwell sharwell self-assigned this Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sharwell sharwell

Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sharwell @tmaczynski