Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart does not allow for a different namespace #12

Open
draganm opened this issue Nov 8, 2022 · 5 comments
Open

helm chart does not allow for a different namespace #12

draganm opened this issue Nov 8, 2022 · 5 comments

Comments

@draganm
Copy link

draganm commented Nov 8, 2022

Current chart is just a single YAML without any variables.
It forces creation of doppler-operator-system, which is not the default behaviour of most other helm charts from other projects.

@nmanoogian
Copy link
Member

Hi @draganm, thanks for calling this out 👍

To confirm, you would have expected the operator namespace to be configurable as a variable in the chart?

@draganm
Copy link
Author

draganm commented Nov 8, 2022

yes, and also this not to be part of the chart (currently in templates/all.yaml):

apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: controller-manager
  name: doppler-operator-system

it's wrong on many levels ...

  • helm will create a namespace for you if you pass the --create-namespace parameter
  • it completely ignores the namespace parameter that helm will pass
  • it makes hashicorp/helm terraform provider fail when namespace parameter is passed, even if the value is doppler-operator-system

@nmanoogian
Copy link
Member

Gotcha, thanks again for the feedback! We'll keep you posted here with any updates.

@adambozson
Copy link

adambozson commented Nov 11, 2022

+1 This is unusual behaviour. Currently the installation namespace needs to be different to doppler-operator-system or the install fails. I suggest removing the Namespace resource and setting the metadata.namespace value in other resources to either:

  • {{ .Release.Namespace }}, or
  • {{ .Values.namespace }} with an associated namespace key/value pair in values.yaml

@emmeowzing
Copy link

I presently don't know how to install these Helm charts on my cluster without downloading the tarballs and removing this namespace object. You could also do a lookup function to see if it exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants