Container max-height support

[romangutkin]

No description provided.

[DominikSerafin]

Hey @romangutkin have you tried wrapping the Vuebar elements with element that has max-height?

[erezger]

hey @DominikSerafin i did trying and it's not helping
not working without height on the vubar element

[marchuksergii]

@DominikSerafin thanks. its working.
@erezger here is mine structure, mb it helps

<div class="vb" v-bar>
            <div>
              <div style="max-height: 190px">
                // scrollable content here
              </div>
            </div>
        </div>

[GsHeri]

ohhhh GOD PLEASE write somewhere prominent in the docs that you have to specify height and not max-height.
i've spent an hour of my life banging my head and wondering why the hell it doesn't work

[DominikSerafin]

Hey @GsHeri sorry you had this experience - I'll try to include that information when I'll have time to update docs. I'll also gladly accept any PRs related to that!

[kruchy8]

Same here, please update docs with info about height property

[dolbex]

lol - first, why don't you guys just edit the docs through a PR? Open Source needs everyone's help....

Second, none of the suggestions posted here worked for me but the following did:

        <div v-bar="{preventParentScroll: true}">
          <div style="max-height:50vh">
            ... content ...
         </div>
       </div>

[DominikSerafin]

I know I don't have perfect history of merging Vuebar PRs, but mostly it's because I haven't written any tests yet, and I don't have time to test every PR manually. But when it comes to docs I shouldn't have this problem and I'll accept any PR more or less instantly.

PS. If someone wants to write some tests I'm open to it :P I could even provide BrowserStack account that I got for free on open-source terms for testing Vuebar. Just please first open new issue where you'll describe your approach for testing so I can green light it.