Skip to content

Commit bb5711f

Browse files
committed
revert: Modal alignment to middle at breakpoint adjustment
ref: 3aefefb
1 parent 3aefefb commit bb5711f

File tree

4 files changed

+10
-16
lines changed

4 files changed

+10
-16
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.
44

5+
# v23.2.2
6+
7+
- [Fix] Revert "Adjust modal alignment to the middle of the viewport at `800px` breakpoint for improved UX". Turns out that this is not something that we want to do.
8+
59
# v23.2.1
610

711
- [Fix] Adjust modal alignment to the middle of the viewport at `800px` breakpoint for improved UX.

package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"email": "[email protected]",
77
"url": "http://doist.com"
88
},
9-
"version": "23.2.1",
9+
"version": "23.2.2",
1010
"license": "MIT",
1111
"homepage": "https://github.com/Doist/reactist#readme",
1212
"repository": {

src/modal/modal.module.css

+3-13
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@
4343
.overlay.fitContent > [data-focus-lock-disabled] {
4444
padding-top: var(--reactist-modal-padding-top);
4545
}
46+
.overlay.fitContent > [data-focus-lock-disabled] .container {
47+
max-height: calc(100vh - 2 * var(--reactist-modal-padding-top));
48+
}
4649

4750
.container {
4851
box-shadow: 0px 2px 8px 0px rgba(0, 0, 0, 0.16);
@@ -115,19 +118,6 @@
115118
}
116119
}
117120

118-
@media (min-height: 800px) {
119-
.overlay.fitContent > [data-focus-lock-disabled] .container {
120-
max-height: calc(100vh - 2 * var(--reactist-modal-padding-top));
121-
}
122-
}
123-
124-
@media (max-height: 800px) {
125-
.overlay.fitContent > [data-focus-lock-disabled] {
126-
padding-top: var(--reactist-spacing-xxlarge);
127-
justify-content: center;
128-
}
129-
}
130-
131121
/* header */
132122

133123
.buttonContainer {

0 commit comments

Comments
 (0)