Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add true "toggle" (checkbox on/off) capability to toggle handlers #49

Open
briandominick opened this issue Jun 13, 2021 · 0 comments
Open
Labels
enhancement New feature or request JavaScript Involves some JS struggles Liquid Incorporates Liquid templating

Comments

@briandominick
Copy link
Contributor

briandominick commented Jun 13, 2021

The original idea for toggle handlers included facet-style toggles for classes independent of others. So, a direct show/hide toggle for one class at a time, checkbox style.

I don't think there's any complex logic in here -- if multiple competing classes are assigned to an element/block, we might want the ability to select an all or one paradigm, whereby a class will show only when all classes are toggled on or when at least one is. We probably want to incorporate that as much as we can to leave the options wide open.

This did not make it into #48, but it should get in by 1.0.

@briandominick briandominick added enhancement New feature or request Liquid Incorporates Liquid templating JavaScript Involves some JS struggles labels Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request JavaScript Involves some JS struggles Liquid Incorporates Liquid templating
Projects
None yet
Development

No branches or pull requests

1 participant