Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dark theme #35

Open
briandominick opened this issue May 25, 2021 · 0 comments
Open

Add a dark theme #35

briandominick opened this issue May 25, 2021 · 0 comments
Labels
CSS/Sass Involves hacking some styles

Comments

@briandominick
Copy link
Contributor

I cannot believe I'm only just now adding this, but this theme absolutely should have a version with light text on a dark background. This is the style I prefer personally, when done right. Admittedly, I have never done it, as no customer has asked me for it, but I would love to have all my docs in a site like Jekyll's docs or even GitHub's dark theme.

Also wondering if we should stop using "skins" as a way to describe the "look and feel" of the very front-end. It doesn't feel great to use terms like "dark" and "light" with that word in this context.

This should obviously wait until after #24, but I think it is a goal for relatively early (0.3.0?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS/Sass Involves hacking some styles
Projects
None yet
Development

No branches or pull requests

1 participant