Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On mobile, site and subject navs should be collapsable menus #33

Open
briandominick opened this issue May 25, 2021 · 2 comments
Open

On mobile, site and subject navs should be collapsable menus #33

briandominick opened this issue May 25, 2021 · 2 comments
Labels
CSS/Sass Involves hacking some styles good first issue Good for newcomers
Milestone

Comments

@briandominick
Copy link
Contributor

The mobile version has 2 obvious problems: a margin along the right side and menus that are way too big at the top.

sceenshot-asciidocsy-mobile

The menus should be collapsed to a hamburger button so the reader sees some content before scrolling.

@briandominick briandominick added good first issue Good for newcomers CSS/Sass Involves hacking some styles labels May 25, 2021
@briandominick
Copy link
Contributor Author

briandominick commented May 25, 2021

On second thought, maybe the initial behavior is just to collapse the subject menus by default on mobile.

screenshot-asciidocsy-mobile-menus-collapsed

Some of that margin can be removed, and maybe just the site nav goes into a hamburger button?

Also here's how that is done in Bootstrap 4.

(Also that weird margin has disappeared wuh?)

@briandominick
Copy link
Contributor Author

And maybe the breadcrumbs should go above the collapsed subject menus.

@briandominick briandominick added this to the 0.3.0 milestone Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS/Sass Involves hacking some styles good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant