Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vendor source handling #32

Open
briandominick opened this issue May 25, 2021 · 0 comments
Open

Improve vendor source handling #32

briandominick opened this issue May 25, 2021 · 0 comments
Labels
CSS/Sass Involves hacking some styles help wanted Extra attention is needed JavaScript Involves some JS struggles
Milestone
0.3.0

Comments

@briandominick
Copy link
Contributor

When we're delivering this theme as a gem, we don't want a bunch of unaltered vendor code in the package. Create a vendor/ or preferably assets/vendor/ path and a way to get necessary upstream code into that path before build-time. I have admittedly not done this before, but I'm going to require it for the Gemification epic (#31).

Or maybe I'm wrong about this. Feedback or research should yield a confident answer.
@briandominick briandominick added help wanted Extra attention is needed CSS/Sass Involves hacking some styles JavaScript Involves some JS struggles labels May 25, 2021
This was referenced May 25, 2021
Open
Open
@briandominick briandominick added this to the 0.3.0 milestone Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS/Sass Involves hacking some styles help wanted Extra attention is needed JavaScript Involves some JS struggles
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@briandominick