Is it possible to add dataChannel on this code?

[siyeol]

Hello,
I am thankfully using this code on my project.
However, I need to add datachannel so that webRTC could share JSON..
Is there any way I could add those functions?

Can I just add these codes
const peerConnection = new RTCPeerConnection(configuration);
const dataChannel = peerConnection.createDataChannel();
on public/js/main.js ??

[Dirvann]

Yeah you can make a PR if you want

[siyeol]

I made a PR! Plz check

[siyeol]

Dear Mr.Vanberveren Hello, I am Siyeol Choi who asked for availability of additional function. I made a pull request about adding a Text Chat on your code. I did not use dataChannel since your code does signaling with Socket.io, so I thought it would be more advantageous to use Socket.io rather than to make another dataChannel Connection. If you don't mind could you please merge it into the main Branch? Sincerely, Siyeol Choi

…

-----Original Message----- From: "Dirk ***@***.***> To: ***@***.***>; Cc: "Siyeol ***@***.***>; ***@***.***>; Sent: 2021-11-08 (월) 21:10:16 (GMT+09:00) Subject: Re: [Dirvann/webrtc-video-conference-simple-peer] Is it possible to add dataChannel on this code? (Discussion #11) Yeah you can make a PR if you want — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.