Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWM] About box support multiple language #85

Open
lin-d-hop opened this issue Nov 22, 2024 · 5 comments
Open

[CWM] About box support multiple language #85

lin-d-hop opened this issue Nov 22, 2024 · 5 comments

Comments

@lin-d-hop
Copy link

No description provided.

@lin-d-hop
Copy link
Author

@ColmDC are there translations for this? Shall I make an actual issue?

@ColmDC
Copy link

ColmDC commented Nov 22, 2024

Shall I make an actual issue?
Sure. I was going to flesh it out later.

Text needs to go here I believe. https://github.com/DigitalCommons/cwm-test-data/blob/delhi-demo/datasets/delhi/about.md

@ColmDC
Copy link

ColmDC commented Nov 22, 2024

are there translations for this?

I have just been chasing that now...

@rogup
Copy link
Contributor

rogup commented Nov 23, 2024

It looks like the text currently being used is just plain and doesn't use any markdown syntax, which the app supports.

If we don't care about markdown (e.g. for section headings, bold, italics, etc.), a very easy way to do this would be to just add the about text in each language as a ui vocab string.

If we want to keep the option of using markdown syntax, we might need to make a folder of markdown files, one for each language, which can be served by the API.

Any preference for this? @ColmDC

@ColmDC
Copy link

ColmDC commented Dec 18, 2024

I think having a seperate markdown file for each language seems to breaks with the multi-lang support in the rest of the application. Let's leave out the complication of MD support for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants