-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
withEverything query. #10
Comments
It is broken into pieces because that's what graphql is for, there is no reason to fetch all the data at the same time. |
I'm fine with graphql being on top of anything as an extra, I just think the core api call should be fetching everything for the sake of making less calls. then whatever interfaces the fetched data can be graphql or sqlite or anything really. Caching for the sake of keeping the rate limiting in bounds, so that there is a middle hop, once data is in cache then graphQL can make any amount of calls to it. Also in case anilist decides to change the API, the data is already cached and if something were to change, it wouldn't affect the library because its working on previously fetched data. |
Currently its in a state of everything breaks if anilist is down. |
The core anilist api is graphql, there is no reason for the library to fetch everything, you as the developer should know what your app needs and fetch accordingly. And of course the wrapper wont work if anilist is down, thats normal. |
is there a reason why you're breaking it down into parts and not just query with everything there is to query? I'd say that would be great + if you can cache everything you query so that no duplicate queries exist. That way once you cache the result, the next query to be made doesn't have to call the rate limited api.
The text was updated successfully, but these errors were encountered: