Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Seeding Input with new BannerComponent #642

Open
FutzMonitor opened this issue Apr 4, 2023 · 1 comment
Open

Updating Seeding Input with new BannerComponent #642

FutzMonitor opened this issue Apr 4, 2023 · 1 comment
Labels
enhancement Improvement to the project Good Second Issue Issue that is a little deeper than a Good First Issue. Reserved Issue created and reserved for use in a course. UI/UX User Interface / User Experience Improvement

Comments

@FutzMonitor
Copy link
Collaborator

Desired Design

Currently the Seeding Input form still makes use of the ErrorBannerComponent. However, the merging of #622 means that these instances need to be removed and the page adequately updated with new data variables to handle the newer BannerComponent.

It's also necessary to consider what new constants need to be added to the BannerMessageConstants.js specifically for the Seeding Input form.

Here are the necessary changes to complete this issue:

  • Should the banner be closed by pressing an 'X' or should it be timeout based? Whatever is decided should be consistent in all pages,
  1. Remove the ErrorBannerComponent from the page.
  2. Import the BannerComponent into the page (simply add it to the Vue instance in the page).
  3. Add the necessary data variables to support
  4. Update pre-existing functions to make the BannerComponent visible, give the correct object, and handle visibility changes.
  5. Remove the banner we're using under the Seeding Input's title. This can be found on lines #4 and ends on line #12.
@braughtg braughtg added enhancement Improvement to the project Reserved Issue created and reserved for use in a course. UI/UX User Interface / User Experience Improvement Good Second Issue Issue that is a little deeper than a Good First Issue. labels Apr 8, 2023
@braughtg
Copy link
Member

braughtg commented Apr 8, 2023

In addition, an appropriate spec.js file containing e2e tests for all uses of the BannerComponent in the page should be included in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to the project Good Second Issue Issue that is a little deeper than a Good First Issue. Reserved Issue created and reserved for use in a course. UI/UX User Interface / User Experience Improvement
Projects
None yet
Development

No branches or pull requests

2 participants