Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for command SET #69

Open
arpitbbhayani opened this issue Oct 31, 2022 · 5 comments
Open

Tests for command SET #69

arpitbbhayani opened this issue Oct 31, 2022 · 5 comments

Comments

@arpitbbhayani
Copy link
Contributor

Currently, there are almost no unit tests for the SET command. We need a comprehensive test suite for this command that also checks the correctness and completeness.

  1. covers the correctness of single command
  2. covers the correctness when multiple commands are fired
  3. no commands are dropped abruptly
  4. ensure we check for small, large, and massive inputs (if applicable)
@sahil1913
Copy link
Contributor

@arpitbbhayani for SET command the tests are in set_test.go.
Are more tests required for it?

@arpitbbhayani
Copy link
Contributor Author

Yes. Correctness is yet to be tested. Long input, different data types, and bulk commands.

ayo-ajayi added a commit to ayo-ajayi/dice that referenced this issue Sep 16, 2023
ayo-ajayi added a commit to ayo-ajayi/dice that referenced this issue Sep 16, 2023
ayo-ajayi added a commit to ayo-ajayi/dice that referenced this issue Sep 16, 2023
@nihcas700
Copy link

@arpitbbhayani I have made some code changes for this task, would be great to have the permissions to open a PR.

@lucifercr07
Copy link
Contributor

@nihcas700 you can fork the repo and raise a PR, no other permissions are required I believe.

@nihcas700
Copy link

nihcas700 commented Aug 23, 2024

Thanks @lucifercr07. Opened the MR. Looks like there are some conflicts, let me rebase it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants