Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in RESP parser when string has multiple \r #1245

Open
c-harish opened this issue Nov 7, 2024 · 0 comments · May be fixed by #1246
Open

Inconsistency in RESP parser when string has multiple \r #1245

c-harish opened this issue Nov 7, 2024 · 0 comments · May be fixed by #1246

Comments

@c-harish
Copy link
Contributor

c-harish commented Nov 7, 2024

RESP parser doesn't parse the bytes after it encounters first \r and skips the bytes following it.
Ideally we should continue parsing, until we encounter a \r immediately followed by a \n

Fix for this issue will unblock #1089

@AshwinKul28

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1245: Fix RESP parser to parse strings with multiple \r c-harish/dice
1 participant
@c-harish