Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement GETRANGE to support all available datatypes #1194

Open
4 tasks
apoorvyadav1111 opened this issue Oct 24, 2024 · 2 comments · May be fixed by #1224
Open
4 tasks

Enhancement GETRANGE to support all available datatypes #1194

apoorvyadav1111 opened this issue Oct 24, 2024 · 2 comments · May be fixed by #1224
Assignees
@c-harish
Labels
difficulty-level -- easy enhancement good first issue Good for newcomers stack -- go

Comments

@apoorvyadav1111
Copy link
Contributor

apoorvyadav1111 commented Oct 24, 2024 •
edited
Loading

Hi team,

Command GETRANGE has recently been migrated and missed support for all available datatypes. We need to make it consistent with Redis. For more context, please go through #1095 comments and unresolved review comments.

Requirements:

  • All datatypes are supported and error handling must be consistent.
  • updating unit tests to cover new enhancement
  • updating all integration test to test new enhancement
  • documentation updates with new enhancement

Thanks
@c-harish
Copy link
Contributor

@apoorvyadav1111 Can i pick this up?

@apoorvyadav1111
Copy link
Contributor Author

Hi @c-harish, Thanks for picking this up.

@c-harish c-harish linked a pull request Oct 30, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c-harish c-harish

Labels
difficulty-level -- easy enhancement good first issue Good for newcomers stack -- go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1194: Enhance GETRANGE to support byte array c-harish/dice
2 participants
@apoorvyadav1111 @c-harish