Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design latency monitoring for DiceDB #1135

Open
JyotinderSingh opened this issue Oct 17, 2024 · 6 comments
Open

Design latency monitoring for DiceDB #1135

JyotinderSingh opened this issue Oct 17, 2024 · 6 comments

Comments

@JyotinderSingh
Copy link
Collaborator

We need to support the different LATENCY commands which redis supports. This requires quite a few changes to the codebase.

Your task as a part of this issue would be to design a latency monitoring approach for dicedb, the approach should allow us to serve all the different latency commands:

  • LATENCY RESET
  • LATENCY HISTORY
  • LATENCY LATEST
  • LATENCY HISTOGRAM (low priority)
  • LATENCY GRAPH (low priority)
@JyotinderSingh
Copy link
Collaborator Author

@swarajrb7 would you be interested in taking this up?

@swarajrb7
Copy link
Contributor

Yes

@JyotinderSingh
Copy link
Collaborator Author

Hey, it may be good to discuss the design before you begin working on the implementation. We need to ensure this does not introduce any performance regressions on the critical path.
Feel free to let us know on discord if you'd like to discuss this in a larger group.

@swarajrb7
Copy link
Contributor

I am researching on how this is implemented in Redis. I do have some questions about it. I will let you know as soon as possible.
@JyotinderSingh

@swarajrb7
Copy link
Contributor

@JyotinderSingh can we discuss this today? i have send a message on discord channel

@swarajrb7
Copy link
Contributor

I am attaching a file in which i have written down my observation and my queries. Please take a look and give me suggestions/improvement to make.
Latency Monitoring in DiceDB.md
@apoorvyadav1111 @JyotinderSingh @AshwinKul28 @lucifercr07

swarajrb7 added a commit to swarajrb7/dice that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants