Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PFCOUNT.WATCH command #1133

Open
JyotinderSingh opened this issue Oct 17, 2024 · 4 comments
Open

Add support for PFCOUNT.WATCH command #1133

JyotinderSingh opened this issue Oct 17, 2024 · 4 comments

Comments

@JyotinderSingh
Copy link
Collaborator

JyotinderSingh commented Oct 17, 2024

Add support for reactive queries on the existing PFCOUNT command by introducing PFCOUNT.WATCH.

This command should send push-responses to subscribed clients whenever the data inside the respective hash set changes.

As a part of this feature, you are also required to add support for the same to the dicedb-go SDK inside the watch_command.go file.

Reference

  1. You may refer to Adds support for ZRANGE.WATCH #1047 to understand the changes required to support this command.
  2. Implements Command Watch Manager and Adds GET.WATCH Command Support #924 provides more background on the feature's underlying implementation (but may not be directly relevant to this issue)

Testing

  1. Ensure integration tests are added, you can refer to existing .WATCH integration tests.
  2. Integration tests should include both resp tests and SDK tests.
@iamskp11
Copy link
Contributor

Would like to work on this @JyotinderSingh .pls assign

@JyotinderSingh
Copy link
Collaborator Author

Would like to work on this @JyotinderSingh .pls assign

Assigned.

@arpitbbhayani
Copy link
Contributor

Hello @iamskp11,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@iamskp11
Copy link
Contributor

Just an update : currently testing the implementation. Will be raising PR by tomorrow EOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants