Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SMEMBERS.WATCH command #1132

Open
JyotinderSingh opened this issue Oct 17, 2024 · 4 comments
Open

Add support for SMEMBERS.WATCH command #1132

JyotinderSingh opened this issue Oct 17, 2024 · 4 comments

Comments

@JyotinderSingh
Copy link
Collaborator

JyotinderSingh commented Oct 17, 2024

Add support for reactive queries on the existing SMEMBERS command by introducing SMEMBERS.WATCH.

This command should send push-responses to subscribed clients whenever the data inside the respective hash set changes.

As a part of this feature, you are also required to add support for the same to the dicedb-go SDK inside the watch_command.go file.

Reference

  1. You may refer to Adds support for ZRANGE.WATCH #1047 to understand the changes required to support this command.
  2. Implements Command Watch Manager and Adds GET.WATCH Command Support #924 provides more background on the feature's underlying implementation (but may not be directly relevant to this issue)

Testing

  1. Ensure integration tests are added, you can refer to existing .WATCH integration tests.
  2. Integration tests should include both resp tests and SDK tests.
@anchalsinghrajput
Copy link

Can I take this up ?

@JyotinderSingh
Copy link
Collaborator Author

Can I take this up ?

Assigned.

@mo-pankaj
Copy link

@anchalsinghrajput are you working on it, if not can I take it?

@anchalsingh25
Copy link
Contributor

hi @mo-pankaj ,

Sorry for the delayed response. Yes, I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants