Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HGETALL.WATCH command #1124

Open
JyotinderSingh opened this issue Oct 17, 2024 · 7 comments
Open

Add support for HGETALL.WATCH command #1124

JyotinderSingh opened this issue Oct 17, 2024 · 7 comments

Comments

@JyotinderSingh
Copy link
Collaborator

JyotinderSingh commented Oct 17, 2024

Add support for reactive queries on the existing HGETALL command by introducing HGETALL.WATCH.

This command should send push-responses to subscribed clients whenever the data inside the respective hash set changes.

As a part of this feature, you are also required to add support for the same to the dicedb-go SDK inside the watch_command.go file.

Reference

  1. You may refer to Adds support for ZRANGE.WATCH #1047 to understand the changes required to support this command.
  2. Implements Command Watch Manager and Adds GET.WATCH Command Support #924 provides more background on the feature's underlying implementation (but may not be directly relevant to this issue)

Testing

  1. Ensure integration tests are added, you can refer to existing .WATCH integration tests.
  2. Integration tests should include both resp tests and SDK tests.
@src1026
Copy link

src1026 commented Oct 17, 2024

Hi! Can I please work on this issue? Thank you : )

@JyotinderSingh
Copy link
Collaborator Author

Hi! Can I please work on this issue? Thank you : )

Assigned.

@abhishekgupta1906
Copy link

Hi, could you please allow me to work on this issue?

@arpit1912
Copy link

Hey @JyotinderSingh let me know the issue is still open, can take a quick look.

@src1026
Copy link

src1026 commented Oct 22, 2024

Hey @arpit1912 ! I was working on it but I kinda got stuck on how to test my changes. I'm new so it took me longer than expected.
Would you mind allowing me more time to look into this issue? Thank you.

@JyotinderSingh
Copy link
Collaborator Author

Hey @arpit1912 ! I was working on it but I kinda got stuck on how to test my changes. I'm new so it took me longer than expected.

Would you mind allowing me more time to look into this issue? Thank you.

Take your time. Feel free to ask on discord.

@arpit1912
Copy link

Hey @arpit1912 ! I was working on it but I kinda got stuck on how to test my changes. I'm new so it took me longer than expected. Would you mind allowing me more time to look into this issue? Thank you.

Please do, I'm also new here and was just checking for an issue to work upon. Let me know if there is anything you want to discuss . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants