Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get repo into a maintainable state #12

Open
olliesilvester opened this issue Dec 17, 2024 · 1 comment
Open

Get repo into a maintainable state #12

olliesilvester opened this issue Dec 17, 2024 · 1 comment

Comments

@olliesilvester
Copy link
Collaborator

olliesilvester commented Dec 17, 2024

There are some tasks we should do to get this project into a more maintainable state:

@olliesilvester
Copy link
Collaborator Author

olliesilvester commented Dec 17, 2024

Here's a brief list of the changes needed to get the dodal branch merged:

  • Create a daq_configuration directory to put the oav parameters in, and use that instead of the OAV.json in dodal

  • Use as much of the oav_detector.py as possible instead of the custom OAV made in the other branch, as there's lots of repeated code.

  • Same as above with the Robot

  • Give the Goniometer device a more specific name based on its functionality. Maybe SixAxesGoniometer or the name of the actual hardware? Consider sharing some of the code that the Smargon uses, to create a base Goniometer class

  • Confirm that MJPG_URL_RBV is a valid PV for other beamlines which use MJPG.py. Same thing for robot RESET.PROC

  • Create a beamline module (analogous to i03.py or i04.py where we can instantiate devices from, to use in our plans

I probably missed some stuff but this will do for the time being!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant