You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here's a brief list of the changes needed to get the dodal branch merged:
Create a daq_configuration directory to put the oav parameters in, and use that instead of the OAV.json in dodal
Use as much of the oav_detector.py as possible instead of the custom OAV made in the other branch, as there's lots of repeated code.
Same as above with the Robot
Give the Goniometer device a more specific name based on its functionality. Maybe SixAxesGoniometer or the name of the actual hardware? Consider sharing some of the code that the Smargon uses, to create a base Goniometer class
Confirm that MJPG_URL_RBV is a valid PV for other beamlines which use MJPG.py. Same thing for robot RESET.PROC
Create a beamline module (analogous to i03.py or i04.py where we can instantiate devices from, to use in our plans
I probably missed some stuff but this will do for the time being!
There are some tasks we should do to get this project into a more maintainable state:
The text was updated successfully, but these errors were encountered: